treat partial errors as callback(err)ors #1760

stephenplusplus · 2016-10-31T19:55:50Z

To Dos

stephenplusplus · 2016-11-01T14:34:32Z

packages/vision/src/index.js

+        .map(decorateAnnotations)
+        .filter(function(annotation) {
+          // Remove annotations that had errors.
+          return annotation;


packages/bigquery/src/table.js

- *   // recommendations on handling errors.
+ *   //   An API error or partial failure occurred.
+ *
+ *   if (err.name === 'PartialFailureError') {


stephenplusplus · 2016-11-07T19:09:33Z

Ready for a final sign off, @callmehiphop!

packages/bigquery/src/table.js

@@ -1015,18 +1015,19 @@ Table.prototype.import = function(source, metadata, callback) {
 * //-
 * function insertHandler(err, insertErrors, apiResponse) {


packages/bigquery/src/table.js

- *   // recommendations on handling errors.
+ *   //   An API error or partial failure occurred.
+ *
+ *   if (err.name === 'PartialFailureError') {


packages/bigquery/src/table.js

+ *
+ *     // err.errors (object[]):
+ *     // err.errors[].row (original row object passed to `insert`)
+ *     // err.errors[].errors[].reason


packages/bigquery/src/table.js

+ *     // err.errors[].errors[].reason
+ *     // err.errors[].errors[].message
+ *
+ *     // See https://developers.google.com/bigquery/troubleshooting-errors for


packages/bigquery/system-test/bigquery.js

+      it('should return partial errors', function(done) {
+        var data = {
+          name: 'dave',
+          breed: 'british shorthair',


packages/bigtable/src/table.js

 *
 * @example
 * //-
 * // Insert entities. See {module:bigtable/table#insert}
 * //-
- * var callback = function(err, mutationErrors) {
+ * var callback = function(err) {
 *   if (err) {


packages/vision/src/index.js

- *   if (detections.faces.errors.length > 0) {
- *     // Errors occurred while trying to use this image for a face annotation.
+ *   if (err && err.name === 'PartialFailureError') {
+ *     err.errors = [


stephenplusplus · 2016-11-07T21:38:28Z

PTAL!

packages/bigquery/system-test/bigquery.js

+      it('should return partial errors', function(done) {
+        var data = {
+          name: 'dave',
+          breed: 'british husky',


stephenplusplus added api: bigquery Issues related to the BigQuery API. don't merge api: bigtable Issues related to the Bigtable API. api: vision Issues related to the Cloud Vision API. labels Oct 31, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2016

callmehiphop reviewed Nov 1, 2016

View reviewed changes

packages/vision/src/index.js

.map(decorateAnnotations)

.filter(function(annotation) {

// Remove annotations that had errors.

return annotation;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop reviewed Nov 1, 2016

View reviewed changes

stephenplusplus mentioned this pull request Nov 2, 2016

common: create PartialFailureError #1764

Merged

stephenplusplus added status: blocked Resolving the issue is dependent on other work. and removed don't merge labels Nov 2, 2016

stephenplusplus force-pushed the spp--1644 branch 3 times, most recently from dc9c83b to 368cde6 Compare November 4, 2016 19:16

stephenplusplus mentioned this pull request Nov 4, 2016

common: add Operation object #1770

Merged

stephenplusplus added 7 commits November 7, 2016 13:40

common: create PartialFailureError

e286754

remove error builder functions

28b8813

treat partial errors as callback(err)ors

c62f93f

add tests for vision

e14bbc7

vision: add docs

47ab270

bigquery: add tests

de9c247

bigtable: tests & docs

8f825c3

stephenplusplus removed the status: blocked Resolving the issue is dependent on other work. label Nov 7, 2016

stephenplusplus force-pushed the spp--1644 branch from 368cde6 to bf50d79 Compare November 7, 2016 18:45

update google-cloud/common

8f0600d

stephenplusplus force-pushed the spp--1644 branch from bf50d79 to 8f0600d Compare November 7, 2016 18:46

stephenplusplus added 2 commits November 7, 2016 13:56

lint

b38cb75

vision: cache original class

9978b93

callmehiphop reviewed Nov 7, 2016

View reviewed changes

docs lint

cfb5d35

stephenplusplus mentioned this pull request Nov 7, 2016

expose failed operations as callback(err) #1644

Closed

doc clarifications

4b1d5cf

callmehiphop reviewed Nov 7, 2016

View reviewed changes

callmehiphop merged commit b6270e5 into googleapis:master Nov 7, 2016

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

treat partial errors as callback(err)ors (#1760)

1e48eb0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

treat partial errors as callback(err)ors #1760

treat partial errors as callback(err)ors #1760

stephenplusplus commented Oct 31, 2016 •

edited

Loading

stephenplusplus commented Nov 1, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Nov 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Nov 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

		@@ -1015,18 +1015,19 @@ Table.prototype.import = function(source, metadata, callback) {
		* //-
		* function insertHandler(err, insertErrors, apiResponse) {

treat partial errors as callback(err)ors #1760

treat partial errors as callback(err)ors #1760

Conversation

stephenplusplus commented Oct 31, 2016 • edited Loading

To Dos

stephenplusplus commented Nov 1, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Nov 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Nov 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Oct 31, 2016 •

edited

Loading