-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added get project api call #2506
Conversation
Changes Unknown when pulling 4ca183c on ashleyschuett:master into ** on GoogleCloudPlatform:master**. |
I'm not sure what test I'm missing, or if this is and acceptable way to implement compute projects. |
Thank you very much for this! I've got a commit coming with some refactors. No worries at all from this point, I'm happy to take it the rest of the way with regards to the tests and coverage. But, I would appreciate a review of the changes I've made, to make sure I'm not overlooking anything. More details coming in a few minutes! |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Changes have been committed, please take a look! I removed Otherwise, I added Thanks again for helping us out! I look forward to your thoughts. |
I debated between implementing it as you have it with the Looks good to me! 👍 |
added get project call https://cloud.google.com/compute/docs/reference/v1/projects
https://cloud.google.com/compute/docs/reference/v1/projects