Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added get project api call #2506

Merged
merged 4 commits into from
Aug 4, 2017
Merged

Conversation

ashleyschuett
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.987% when pulling d4fdc66 on ashleyschuett:master into 3e91324 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4ca183c on ashleyschuett:master into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.848% when pulling 7ddf557 on ashleyschuett:master into 3f05325 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus added the api: compute Issues related to the Compute Engine API. label Aug 4, 2017
@callmehiphop callmehiphop mentioned this pull request Aug 4, 2017
20 tasks
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.987% when pulling 06a12ab on ashleyschuett:master into 3f05325 on GoogleCloudPlatform:master.

@ashleyschuett
Copy link
Contributor Author

I'm not sure what test I'm missing, or if this is and acceptable way to implement compute projects.

@stephenplusplus
Copy link
Contributor

Thank you very much for this! I've got a commit coming with some refactors. No worries at all from this point, I'm happy to take it the rest of the way with regards to the tests and coverage. But, I would appreciate a review of the changes I've made, to make sure I'm not overlooking anything. More details coming in a few minutes!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 4, 2017
@stephenplusplus
Copy link
Contributor

Changes have been committed, please take a look!

I removed compute.getProjects() and compute.getProjectsStream(), because it seems like there's only one project as the resource that the /projects endpoint refers to. Therefore, the user will never be able to list projects. Please correct me if I'm wrong on that.

Otherwise, I added project.get() and project.getMetadata() to fit in with the rest of our API, and re-aliased project.name (the instance variable) to project.id, since name is a different piece of data than ID.

Thanks again for helping us out! I look forward to your thoughts.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4697584 on ashleyschuett:master into 3f05325 on GoogleCloudPlatform:master.

@ashleyschuett
Copy link
Contributor Author

I debated between implementing it as you have it with the get and getMetadata calls and just doing the getProject top call. I like this implementation better.

Looks good to me! 👍

@stephenplusplus stephenplusplus merged commit 471b9df into googleapis:master Aug 4, 2017
@stephenplusplus stephenplusplus removed the cla: no This human has *not* signed the Contributor License Agreement. label Aug 4, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9d62097 on ashleyschuett:master into 3f05325 on GoogleCloudPlatform:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants