storage: download integrity check #310

stephenplusplus · 2014-11-24T17:30:19Z

integrity tests
merge storage: support resumable uploads #299

Picking up from #299, where we're implementing integrity checks for uploads.

ryanseys · 2014-11-24T17:35:01Z

Does this depend on #299 being merged first?

On Monday, November 24, 2014, Stephen Sawchuk [email protected]
wrote:

Picking up from #299
#299, where

we're implementing integrity checks for uploads.

You can merge this Pull Request by running

git pull https://github.com/stephenplusplus/gcloud-node spp--storage-download-integrity

Or view, comment on, or merge it at:

#310
Commit Summary

storage: download integrity check

File Changes

M lib/storage/file.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/310/files#diff-0
(73)

M regression/storage.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/310/files#diff-1
(13)

M test/storage/file.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/310/files#diff-2
(36)

Patch Links:

https://github.com/GoogleCloudPlatform/gcloud-node/pull/310.patch

https://github.com/GoogleCloudPlatform/gcloud-node/pull/310.diff

—
Reply to this email directly or view it on GitHub
#310.

stephenplusplus · 2014-11-24T17:36:54Z

No, sir.

lib/storage/file.js

+            } else {
+              var error = new Error([
+                'The downloaded data did not match the data from the server. ',
+                'To be sure the content is the same, you should download the',


lib/storage/file.js

+  var that = this;
+  var throughStream = through();
+
+  this.getMetadata(function(err, metadata) {


stephenplusplus · 2014-12-01T18:25:31Z

@ryanseys going to re-answer your earlier question. It probably makes sense to wait for #299 to go before merging this one, since there will be some shared functions I can make use of in this PR that are going to go with that PR.

Left a note to hold off in the description 👍

stephenplusplus · 2014-12-05T19:08:39Z

This one should be ready for another look.

lib/storage/file.js

  }
+
+  if (util.is(options.validation, 'undefined')) {
+    validation = 'all';


ryanseys · 2014-12-08T05:28:38Z

I've looked at this. It looks overall good, just a few notes you may wish to address. If you make those small changes and squash, I'll be happy to merge.

https://github.com/GoogleCloudPlatform/gcloud-node/pull/310\#discussion-diff-21434792

stephenplusplus · 2014-12-08T20:26:16Z

Thanks for the review! I squashed and tried to make the docs a little more clear in 88e9eab

stephenplusplus · 2014-12-10T17:44:16Z

@ryanseys squashed and fixed the logic line you left a comment on. Merging!

…tegrity storage: download integrity check

* fix: make `generate_index_ts()` deterministic (#1104) Fixes googleapis/synthtool#1103 Source-Link: googleapis/synthtool@c3e41da Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:e37a815333a6f3e14d8532efe90cba8aa0d34210f8c0fdbdd9e6a34dcbe51e96 * fix: regular expression matches v1, v1beta1 in order * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Jeffrey Rennie <[email protected]>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^11.0.0` -> `^12.0.0`](https://renovatebot.com/diffs/npm/sinon/11.1.2/12.0.1) | [![age](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/compatibility-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/confidence-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v12.0.1`](https://togithub.com/sinonjs/sinon/blob/master/CHANGES.md#1201) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v12.0.0...v12.0.1) - [`3f598221`](https://togithub.com/sinonjs/sinon/commit/3f598221045904681f2b3b3ba1df617ed5e230e3) Fix issue with npm unlink for npm version > 6 (Carl-Erik Kopseng) > 'npm unlink' would implicitly unlink the current dir > until version 7, which requires an argument - [`51417a38`](https://togithub.com/sinonjs/sinon/commit/51417a38111eeeb7cd14338bfb762cc2df487e1b) Fix bundling of cjs module ([#2412](https://togithub.com/sinonjs/sinon/issues/2412)) (Julian Grinblat) > - Fix bundling of cjs module > > - Run prettier *Released by [Carl-Erik Kopseng](https://togithub.com/fatso83) on 2021-11-04.* #### 12.0.0 ### [`v12.0.0`](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-secret-manager).

…andwritten libraries (#310) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9 feat: add `symbols` field, and auto-format comments PiperOrigin-RevId: 428800506 Source-Link: googleapis/googleapis@ea20380 Source-Link: googleapis/googleapis-gen@8b9ece5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGI5ZWNlNTA4YzEzMjUxNmY0YmY3OWU0NjJmMDgyNTNhY2M4NTkzNSJ9 feat: add `symbols` field, and auto-format comments PiperOrigin-RevId: 428799963 Source-Link: googleapis/googleapis@8b6181f Source-Link: googleapis/googleapis-gen@2c320a9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmMzMjBhOTU2MTYwZWU4NmNiOGQ3OTIzZTM3YTFhM2E0NTFkMTA0MiJ9

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-loader](https://togithub.com/TypeStrong/ts-loader) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/ts-loader/8.1.0/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/compatibility-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/ts-loader/9.0.0/confidence-slim/8.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v9.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v900) [Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v8.1.0...v9.0.0) Breaking changes: - minimum webpack version: 5 - minimum node version: 12 Changes: - [webpack 5 migration](https://togithub.com/TypeStrong/ts-loader/pull/1251) - thanks [@johnnyreilly](https://togithub.com/johnnyreilly), [@jonwallsten](https://togithub.com/jonwallsten), [@sokra](https://togithub.com/sokra), [@appzuka](https://togithub.com/appzuka), [@alexander-akait](https://togithub.com/alexander-akait) </details> --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-talent).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.7](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/compare/v2.1.6...v2.1.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#309](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/issues/309)) ([de80090](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/commit/de800902327bad13ee6145ecbbb6b90d11cb8f59)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: sofisl <[email protected]>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^11.0.0` -> `^12.0.0`](https://renovatebot.com/diffs/npm/sinon/11.1.2/12.0.1) | [![age](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/compatibility-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/confidence-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v12.0.1`](https://togithub.com/sinonjs/sinon/blob/master/CHANGES.md#1201) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v12.0.0...v12.0.1) - [`3f598221`](https://togithub.com/sinonjs/sinon/commit/3f598221045904681f2b3b3ba1df617ed5e230e3) Fix issue with npm unlink for npm version > 6 (Carl-Erik Kopseng) > 'npm unlink' would implicitly unlink the current dir > until version 7, which requires an argument - [`51417a38`](https://togithub.com/sinonjs/sinon/commit/51417a38111eeeb7cd14338bfb762cc2df487e1b) Fix bundling of cjs module ([#2412](https://togithub.com/sinonjs/sinon/issues/2412)) (Julian Grinblat) > - Fix bundling of cjs module > > - Run prettier *Released by [Carl-Erik Kopseng](https://togithub.com/fatso83) on 2021-11-04.* #### 12.0.0 ### [`v12.0.0`](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-datacatalog).

stephenplusplus force-pushed the spp--storage-download-integrity branch 2 times, most recently from 64aa8dc to b4f3d8d Compare November 24, 2014 17:33

ryanseys reviewed Nov 24, 2014
View reviewed changes

lib/storage/file.js

} else {

var error = new Error([

'The downloaded data did not match the data from the server. ',

'To be sure the content is the same, you should download the',

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the spp--storage-download-integrity branch from 6021be0 to 9367598 Compare November 24, 2014 18:26

stephenplusplus mentioned this pull request Nov 24, 2014

storage: support resumable uploads #299

Merged

6 tasks

stephenplusplus reviewed Nov 24, 2014
View reviewed changes

stephenplusplus force-pushed the spp--storage-download-integrity branch from 9eaef75 to 14b48b5 Compare November 25, 2014 20:01

stephenplusplus force-pushed the spp--storage-download-integrity branch from a1b2671 to 3df8817 Compare December 5, 2014 18:50

ryanseys reviewed Dec 8, 2014
View reviewed changes

lib/storage/file.js

}

if (util.is(options.validation, 'undefined')) {

validation = 'all';

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the spp--storage-download-integrity branch from 8426ceb to 4f03ef7 Compare December 8, 2014 20:25

stephenplusplus referenced this pull request in stephenplusplus/gcloud-node Dec 8, 2014

storage: clarify documentation about download integrity

4f03ef7

https://github.com/GoogleCloudPlatform/gcloud-node/pull/310\#discussion-diff-21434792

stephenplusplus force-pushed the spp--storage-download-integrity branch from 4f03ef7 to 88e9eab Compare December 8, 2014 20:25

stephenplusplus referenced this pull request in stephenplusplus/gcloud-node Dec 8, 2014

storage: clarify documentation about download integrity

88e9eab

https://github.com/GoogleCloudPlatform/gcloud-node/pull/310\#discussion-diff-21434792

storage: download integrity check

c7c6e60

stephenplusplus force-pushed the spp--storage-download-integrity branch from 9802af2 to c7c6e60 Compare December 10, 2014 17:43

stephenplusplus added a commit that referenced this pull request Dec 10, 2014

Merge pull request #310 from stephenplusplus/spp--storage-download-in…

23d399c

…tegrity storage: download integrity check

stephenplusplus merged commit 23d399c into googleapis:master Dec 10, 2014

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-scheduler #3547

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-containeranalysis #3550

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-secret-manager #3553

Merged

migrate code from googleapis/nodejs-document-ai #3559

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloudbuild #3566

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-talent #3568

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-game-servers #3569

Merged

migrate code from googleapis/nodejs-dialogflow-cx #3602

Merged

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

feat: add avro support (#310)

38906dc

sofisl pushed a commit that referenced this pull request Jan 24, 2023

build: update release config (#310)

4b054b3

sofisl pushed a commit that referenced this pull request Jan 25, 2023

build: update release config (#310)

0cf3fe1

sofisl pushed a commit that referenced this pull request Sep 14, 2023

fix(typescript): make dnsName a required field (#310)

611f487

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

WontonSam mentioned this pull request May 13, 2024

[Snyk] Upgrade @octokit/rest from 19.0.0 to 19.0.13 WontonSam/Bekki13-cloud-node#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: download integrity check #310

storage: download integrity check #310

stephenplusplus commented Nov 24, 2014

ryanseys commented Nov 24, 2014

we're implementing integrity checks for uploads.

stephenplusplus commented Nov 24, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Dec 1, 2014

stephenplusplus commented Dec 5, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Dec 8, 2014

stephenplusplus commented Dec 8, 2014

stephenplusplus commented Dec 10, 2014

storage: download integrity check #310

storage: download integrity check #310

Conversation

stephenplusplus commented Nov 24, 2014

ryanseys commented Nov 24, 2014

we're implementing integrity checks for uploads.

stephenplusplus commented Nov 24, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Dec 1, 2014

stephenplusplus commented Dec 5, 2014

This comment was marked as spam.

This comment was marked as spam.

ryanseys commented Dec 8, 2014

stephenplusplus commented Dec 8, 2014

stephenplusplus commented Dec 10, 2014