Storage: File: add bucket check #353

coderaiser · 2015-01-17T17:24:01Z

Added bucket check same as name has.

stephenplusplus · 2015-01-17T17:43:25Z

That error is actually only there because of this: https://github.com/coderaiser/gcloud-node/blob/patch-1/lib/storage/bucket.js#L201 -- a user has control of the second argument, but not the first.

A File instance is only created by our library. A user does not directly instantiate a File object without going through our methods that internally create them, always providing the first argument (bucket) for the user. Did you run into a problem where an error should have been thrown?

coderaiser · 2015-01-17T20:22:55Z

No, but I think that all necessary arguments should be checked.
Anyway maybe arguments check should be in Bucket.prototype.file,
in function users interacting with. It has more sense becouse name is the only one argument which shoud be passed.

stephenplusplus · 2015-01-17T23:32:00Z

👍 to checking and throwing in Bucket#file. I don't believe file objects can be created by name in any other part of the library.

If you'd like to change this PR to just move the error catching from the File constructor to the Bucket#file method, that'd be great. And even better if you can update/add tests to suit the new structure.

ryanseys · 2015-01-18T01:45:00Z

I'm okay with Bucket#file too but I don't think putting it in File is wrong because when creating a File object, you DEFINITELY needs to go through File constructor but should not necessarily need to go through Bucket (even though our library only does that). Depends how much defensive programming you want to do. I'll be content with either but to be honest, think closer to File the better.

stephenplusplus · 2015-01-18T01:50:55Z

I'm fine with that as well. Let's let @coderaiser decide :)

ryanseys · 2015-01-18T02:12:07Z

In either case, whatever you decide @coderaiser, a test would be a great addition to this PR! 😄

coderaiser · 2015-01-18T11:17:55Z

name check moved to Bucket.prototype.file from File.
Tests has been updated.

test/storage/bucket.js

+    it('should throw if no name was provided', function() {
+      assert.throws(function() {
+        file = bucket.file();
+      }, /A file name must be specified./);


ryanseys · 2015-01-18T17:08:24Z

So I think that either the bucket check gets added to the File constructor like originally was done or the check doesn't get added at all because by checking for Bucket object in a Bucket method is silly.

stephenplusplus · 2015-01-20T14:47:37Z

We'll just leave things the way they are. Thanks @coderaiser :)

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/37f383f8-7560-459e-b66c-def10ff830cb/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@b10590a

* [CHANGE ME] Re-generated to pick up changes in the API or client library generator. * fix: regenerated proto.d.ts Co-authored-by: Alexander Fenster <[email protected]>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2a81bca4-7abd-4108-ac1f-21340f858709/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@dc9caca

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/37f383f8-7560-459e-b66c-def10ff830cb/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@b10590a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e

samples: pull in latest typeless bot, clean up some comments Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

🤖 I have created a release *beep* *boop* --- ## [3.1.3](https://togithub.com/googleapis/nodejs-game-servers/compare/v3.1.2...v3.1.3) (2022-11-10) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#349](https://togithub.com/googleapis/nodejs-game-servers/issues/349)) ([879eea3](https://togithub.com/googleapis/nodejs-game-servers/commit/879eea37422f58286d3e39e27f5c1b2f6aa4ae9c)) * Regenerated protos JS and TS definitions ([#353](https://togithub.com/googleapis/nodejs-game-servers/issues/353)) ([21535e1](https://togithub.com/googleapis/nodejs-game-servers/commit/21535e16d9dc28888514414117e463271383a971)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

docs: update taxonomy display_name comment feat: added Dataplex specific fields PiperOrigin-RevId: 440386238 Source-Link: googleapis/googleapis@99fd8be Source-Link: googleapis/googleapis-gen@e132e73 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTEzMmU3M2U1MTRlZDdhMzAwOWU2OWRlODI0OGEzNjRiODg3OGNiOCJ9 See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

fix: include 'x-goog-request-params' header in requests This PR was generated using Autosynth. 🌈 Here's the log from Synthtool: ``` synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py. synthtool > Ensuring dependencies. synthtool > Pulling artman image. latest: Pulling from googleapis/artman Digest: sha256:e3c054a2fb85a12481c722af616c7fb6f1d02d862248385eecbec3e4240ebd1e Status: Image is up to date for googleapis/artman:latest synthtool > Cloning googleapis. synthtool > Running generator for google/cloud/vision/artman_vision_v1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1. synthtool > Running generator for google/cloud/vision/artman_vision_v1p1beta1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p1beta1. synthtool > Running generator for google/cloud/vision/artman_vision_v1p2beta1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p2beta1. synthtool > Running generator for google/cloud/vision/artman_vision_v1p3beta1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p3beta1. synthtool > Running generator for google/cloud/vision/artman_vision_v1p4beta1.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p4beta1. .eslintignore .eslintrc.yml .github/ISSUE_TEMPLATE/bug_report.md .github/ISSUE_TEMPLATE/feature_request.md .github/ISSUE_TEMPLATE/support_request.md .jsdoc.js .kokoro/common.cfg .kokoro/continuous/node10/common.cfg .kokoro/continuous/node10/docs.cfg .kokoro/continuous/node10/lint.cfg .kokoro/continuous/node10/samples-test.cfg .kokoro/continuous/node10/system-test-grpcjs.cfg .kokoro/continuous/node10/system-test.cfg .kokoro/continuous/node10/test.cfg .kokoro/continuous/node11/common.cfg .kokoro/continuous/node11/test.cfg .kokoro/continuous/node6/common.cfg .kokoro/continuous/node6/test.cfg .kokoro/continuous/node8/common.cfg .kokoro/continuous/node8/test.cfg .kokoro/docs.sh .kokoro/lint.sh .kokoro/presubmit/node10/common.cfg .kokoro/presubmit/node10/docs.cfg .kokoro/presubmit/node10/lint.cfg .kokoro/presubmit/node10/samples-test.cfg .kokoro/presubmit/node10/system-test-grpcjs.cfg .kokoro/presubmit/node10/system-test.cfg .kokoro/presubmit/node10/test.cfg .kokoro/presubmit/node11/common.cfg .kokoro/presubmit/node11/test.cfg .kokoro/presubmit/node6/common.cfg .kokoro/presubmit/node6/test.cfg .kokoro/presubmit/node8/common.cfg .kokoro/presubmit/node8/test.cfg .kokoro/presubmit/windows/common.cfg .kokoro/presubmit/windows/test.cfg .kokoro/publish.sh .kokoro/release/publish.cfg .kokoro/samples-test.sh .kokoro/system-test.sh .kokoro/test.bat .kokoro/test.sh .kokoro/trampoline.sh .nycrc .prettierignore .prettierrc CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE Skipping: README.md codecov.yaml renovate.json synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1/doc/google/protobuf/doc_timestamp.js. synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1p4beta1/doc/google/protobuf/doc_timestamp.js. synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1p3beta1/doc/google/protobuf/doc_timestamp.js. synthtool > Replaced 'toISOString\\]' in src/v1/doc/google/protobuf/doc_timestamp.js. synthtool > Replaced 'toISOString\\]' in src/v1p4beta1/doc/google/protobuf/doc_timestamp.js. synthtool > Replaced 'toISOString\\]' in src/v1p3beta1/doc/google/protobuf/doc_timestamp.js. > [email protected] install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc > node-pre-gyp install --fallback-to-build --library=static_library node-pre-gyp WARN Using needle for node-pre-gyp https download [grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote > [email protected] postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs > node scripts/postinstall npm notice created a lockfile as package-lock.json. You should commit this file. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) added 1133 packages from 1322 contributors and audited 7110 packages in 25.393s found 3 vulnerabilities (1 low, 2 moderate) run `npm audit fix` to fix them, or `npm audit` for details > @google-cloud/[email protected] fix /tmpfs/src/git/autosynth/working_repo > eslint --fix '**/*.js' synthtool > Cleaned up 2 temporary directories. synthtool > Wrote metadata to synth.metadata. ``` #353 automerged by dpebot

This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2020-03-22 04:12:41,920 synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py. 2020-03-22 04:12:41,972 synthtool > Ensuring dependencies. 2020-03-22 04:12:41,977 synthtool > Cloning googleapis. 2020-03-22 04:12:42,309 synthtool > Pulling Docker image: gapic-generator-typescript:latest latest: Pulling from gapic-images/gapic-generator-typescript Digest: sha256:3762b8bcba247ef4d020ffc7043e2881a20b5fab0ffd98d542f365d3f3a3829d Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest 2020-03-22 04:12:43,271 synthtool > Generating code for: google/cloud/automl/v1beta1. 2020-03-22 04:12:44,627 synthtool > Generated code into /tmpfs/tmp/tmp6irq18wf. 2020-03-22 04:12:44,672 synthtool > Pulling Docker image: gapic-generator-typescript:latest latest: Pulling from gapic-images/gapic-generator-typescript Digest: sha256:3762b8bcba247ef4d020ffc7043e2881a20b5fab0ffd98d542f365d3f3a3829d Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest 2020-03-22 04:12:45,565 synthtool > Generating code for: google/cloud/automl/v1. 2020-03-22 04:12:46,959 synthtool > Generated code into /tmpfs/tmp/tmpq_k0t23o. .eslintignore .eslintrc.yml .github/ISSUE_TEMPLATE/bug_report.md .github/ISSUE_TEMPLATE/feature_request.md .github/ISSUE_TEMPLATE/support_request.md .github/PULL_REQUEST_TEMPLATE.md .github/publish.yml .github/release-please.yml .github/workflows/ci.yaml .kokoro/common.cfg .kokoro/continuous/node10/common.cfg .kokoro/continuous/node10/docs.cfg .kokoro/continuous/node10/lint.cfg .kokoro/continuous/node10/samples-test.cfg .kokoro/continuous/node10/system-test.cfg .kokoro/continuous/node10/test.cfg .kokoro/continuous/node12/common.cfg .kokoro/continuous/node12/test.cfg .kokoro/continuous/node8/common.cfg .kokoro/continuous/node8/test.cfg .kokoro/docs.sh .kokoro/lint.sh .kokoro/presubmit/node10/common.cfg .kokoro/presubmit/node10/docs.cfg .kokoro/presubmit/node10/lint.cfg .kokoro/presubmit/node10/samples-test.cfg .kokoro/presubmit/node10/system-test.cfg .kokoro/presubmit/node10/test.cfg .kokoro/presubmit/node12/common.cfg .kokoro/presubmit/node12/test.cfg .kokoro/presubmit/node8/common.cfg .kokoro/presubmit/node8/test.cfg .kokoro/presubmit/windows/common.cfg .kokoro/presubmit/windows/test.cfg .kokoro/publish.sh .kokoro/release/docs.cfg .kokoro/release/docs.sh .kokoro/release/publish.cfg .kokoro/samples-test.sh .kokoro/system-test.sh .kokoro/test.bat .kokoro/test.sh .kokoro/trampoline.sh .mocharc.js .nycrc .prettierignore .prettierrc CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE README.md codecov.yaml renovate.json samples/README.md 2020-03-22 04:12:47,462 synthtool > Replaced '"recurse": true,' in linkinator.config.json. npm WARN npm npm does not support Node.js v12.16.1 npm WARN npm You should probably upgrade to a newer version of node as we npm WARN npm can't make any promises that npm will work with this version. npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11. npm WARN npm You can find the latest version at https://nodejs.org/ npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3. > [email protected] postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/core-js > node -e "try{require('./postinstall')}catch(e){}" �[96mThank you for using core-js (�[94m https://github.com/zloirock/core-js �[96m) for polyfilling JavaScript standard library!�[0m �[96mThe project needs your help! Please consider supporting of core-js on Open Collective or Patreon: �[0m �[96m>�[94m https://opencollective.com/core-js �[0m �[96m>�[94m https://www.patreon.com/zloirock �[0m �[96mAlso, the author of core-js (�[94m https://github.com/zloirock �[96m) is looking for a good job -)�[0m > [email protected] postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs > node scripts/postinstall > @google-cloud/[email protected] prepare /tmpfs/src/git/autosynth/working_repo > npm run compile npm WARN npm npm does not support Node.js v12.16.1 npm WARN npm You should probably upgrade to a newer version of node as we npm WARN npm can't make any promises that npm will work with this version. npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11. npm WARN npm You can find the latest version at https://nodejs.org/ > @google-cloud/[email protected] compile /tmpfs/src/git/autosynth/working_repo > tsc -p . && cp -r protos build/ npm notice created a lockfile as package-lock.json. You should commit this file. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.1 (node_modules/chokidar/node_modules/fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/watchpack/node_modules/chokidar/node_modules/fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/abbrev): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/abbrev' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.abbrev.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/ansi-regex): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/ansi-regex' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.ansi-regex.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/aproba): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/aproba' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.aproba.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/balanced-match): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/balanced-match' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.balanced-match.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/chownr): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/chownr' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.chownr.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/code-point-at): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/code-point-at' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.code-point-at.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/concat-map): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/concat-map' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.concat-map.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/console-control-strings): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/console-control-strings' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.console-control-strings.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/core-util-is): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/core-util-is' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.core-util-is.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/deep-extend): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/deep-extend' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.deep-extend.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/delegates): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/delegates' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.delegates.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/detect-libc): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/detect-libc' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.detect-libc.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/fs.realpath): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/fs.realpath' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.fs.realpath.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/has-unicode): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/has-unicode' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.has-unicode.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/inherits): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/inherits' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.inherits.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/ini): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/ini' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.ini.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/isarray): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/isarray' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.isarray.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/minimist): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/minimist' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.minimist.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/ms): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/ms' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.ms.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/npm-normalize-package-bin): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/npm-normalize-package-bin' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.npm-normalize-package-bin.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/number-is-nan): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/number-is-nan' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.number-is-nan.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/object-assign): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/object-assign' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.object-assign.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/os-homedir): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/os-homedir' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.os-homedir.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/os-tmpdir): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/os-tmpdir' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.os-tmpdir.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/path-is-absolute): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/path-is-absolute' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.path-is-absolute.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/process-nextick-args): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/process-nextick-args' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.process-nextick-args.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/safe-buffer): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/safe-buffer' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.safe-buffer.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/safer-buffer): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/safer-buffer' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.safer-buffer.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/sax): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/sax' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.sax.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/semver): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/semver' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.semver.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/set-blocking): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/set-blocking' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.set-blocking.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/signal-exit): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/signal-exit' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.signal-exit.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/strip-json-comments): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/strip-json-comments' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.strip-json-comments.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/util-deprecate): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/util-deprecate' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.util-deprecate.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/wrappy): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/wrappy' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.wrappy.DELETE' npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents/node_modules/yallist): npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/yallist' -> '/tmpfs/src/git/autosynth/working_repo/node_modules/watchpack/node_modules/fsevents/node_modules/.yallist.DELETE' added 1003 packages from 553 contributors and audited 6825 packages in 28.162s found 0 vulnerabilities npm WARN npm npm does not support Node.js v12.16.1 npm WARN npm You should probably upgrade to a newer version of node as we npm WARN npm can't make any promises that npm will work with this version. npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11. npm WARN npm You can find the latest version at https://nodejs.org/ > @google-cloud/[email protected] fix /tmpfs/src/git/autosynth/working_repo > gts fix && eslint --fix samples/*.js /tmpfs/src/git/autosynth/working_repo/samples/batch_predict.js 35:45 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/delete_dataset.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/delete_model.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/deploy_model.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/export_dataset.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/get_dataset.js 36:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/get_model.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/get_model_evaluation.js 38:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/get_operation_status.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/import_dataset.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_entity_extraction_create_dataset.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_entity_extraction_create_model.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_entity_extraction_predict.js 33:45 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_sentiment_analysis_create_dataset.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_sentiment_analysis_create_model.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_sentiment_analysis_predict.js 33:45 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_text_classification_create_dataset.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_text_classification_create_model.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/language_text_classification_predict.js 33:45 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/list_datasets.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/list_model_evaluations.js 36:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/list_models.js 26:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/list_operation_status.js 26:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/quickstart.js 25:26 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/translate_create_dataset.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/translate_create_model.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/translate_predict.js 33:45 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/undeploy_model.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_classification_create_dataset.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_classification_create_model.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_classification_deploy_model_node_count.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_classification_predict.js 33:45 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_object_detection_create_dataset.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_object_detection_create_model.js 33:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_object_detection_deploy_model_node_count.js 31:34 error "@google-cloud/automl" is not found node/no-missing-require /tmpfs/src/git/autosynth/working_repo/samples/vision_object_detection_predict.js 33:45 error "@google-cloud/automl" is not found node/no-missing-require ✖ 36 problems (36 errors, 0 warnings) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! @google-cloud/[email protected] fix: `gts fix && eslint --fix samples/*.js` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the @google-cloud/[email protected] fix script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /home/kbuilder/.npm/_logs/2020-03-22T11_13_40_269Z-debug.log installing semver@^5.5.0 installing uglify-js@^3.3.25 installing espree@^3.5.4 installing escodegen@^1.9.1 2020-03-22 04:13:50,279 synthtool > Wrote metadata to synth.metadata. ``` </details>

🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.9](https://www.github.com/googleapis/nodejs-dns/compare/v1.2.8...v1.2.9) (2020-03-17) ### Bug Fixes * **deps:** update dependency dns-zonefile to v0.2.6 ([#351](https://www.github.com/googleapis/nodejs-dns/issues/351)) ([437505b](https://www.github.com/googleapis/nodejs-dns/commit/437505b52ab43d7beeb5ce3f5bd6266c1067db96)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2015

Bucket: file: add name check

ae83b82

stephenplusplus reviewed Jan 18, 2015
View reviewed changes

test/storage/bucket.js

it('should throw if no name was provided', function() {

assert.throws(function() {

file = bucket.file();

}, /A file name must be specified./);

This comment was marked as spam.

Sign in to view

stephenplusplus closed this Jan 20, 2015

coderaiser deleted the patch-1 branch January 20, 2015 14:50

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-language #3395

Merged

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: run fix instead of lint in synthfile (#353)

85e74b7

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-container #3543

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): use google-gax v3.5.2 (#353)

ca8ec15

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-web-risk #3549

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: release 3.3.0 (#353)

4c8673b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-containeranalysis #3550

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-grafeas #3551

Merged

migrate code from googleapis/nodejs-document-ai #3559

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-game-servers #3569

Merged

4 tasks

release-please bot mentioned this pull request Nov 11, 2022

chore: release main #3529

Merged

sofisl pushed a commit that referenced this pull request Nov 16, 2022

docs(samples): deleted quickstart file and corresponding test (#353)

29a0e77

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

feat: introduces style enumeration (#353)

5dcf670

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 24, 2023

build: add new kokoro config for coverage and release-please (#353)

80623d6

sofisl pushed a commit that referenced this pull request Jan 25, 2023

build: add new kokoro config for coverage and release-please (#353)

a8f12c1

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage: File: add bucket check #353

Storage: File: add bucket check #353

coderaiser commented Jan 17, 2015

stephenplusplus commented Jan 17, 2015

coderaiser commented Jan 17, 2015

stephenplusplus commented Jan 17, 2015

ryanseys commented Jan 18, 2015

stephenplusplus commented Jan 18, 2015

ryanseys commented Jan 18, 2015

coderaiser commented Jan 18, 2015

This comment was marked as spam.

ryanseys commented Jan 18, 2015

stephenplusplus commented Jan 20, 2015

Storage: File: add bucket check #353

Storage: File: add bucket check #353

Conversation

coderaiser commented Jan 17, 2015

stephenplusplus commented Jan 17, 2015

coderaiser commented Jan 17, 2015

stephenplusplus commented Jan 17, 2015

ryanseys commented Jan 18, 2015

stephenplusplus commented Jan 18, 2015

ryanseys commented Jan 18, 2015

coderaiser commented Jan 18, 2015

This comment was marked as spam.

ryanseys commented Jan 18, 2015

stephenplusplus commented Jan 20, 2015