allow making a bucket public/private #429

stephenplusplus · 2015-03-05T18:57:15Z

Evolves: #418

This introduces:

bucket.makePublic([options], callback)

options

options.includeFiles

Type: boolean
Default: false

Run file.makePublic() against every in the bucket.

options.force

Type: boolean
Default: false

Queue errors occurred while making files public until all files have been processed.

callback(error, [files])

Type: function

error can be null, Error, or Error[].

If you don't specify includeFiles: true, files doesn't exist. If you did, it contains all files successfully made public.

bucket.makePrivate([options], callback)

options

options.strict

Type: boolean
Default: false

Make the bucket private to only the owner user. Otherwise, it will be private to the project.

options.includeFiles

Type: boolean
Default: false

Run file.makePrivate() against every in the bucket.

options.force

Type: boolean
Default: false

Queue errors occurred while making files public until all files have been processed.

callback(error, [files])

Type: function

error can be null, Error, or Error[].

If you don't specify includeFiles: true, files doesn't exist. If you did, it contains all files successfully made private.

Todos

Regression tests
Unit Tests
Docs
~~Add options.auto to apply a predefinedObjectACL on the bucket to allow new files to be created with the same permissions.~~ (this behavior will become default)

Issues

bucket#makePrivate with strict: true always throws an error forbidden before it finishes, because it somehow doesn't recognize my account using service account key json to authenticate as an owner. Any idea how I can become the root owner of the bucket? (applies to @ryanseys and me as well)
- Resolution: Removed strict option: allow making a bucket public/private #429 (comment)

ryanseys · 2015-03-05T20:17:25Z

So thoughts on private issues... we could just remove strict: true? Private to the project seems like smarter than private to specific user anyway.

stephenplusplus · 2015-03-05T20:18:35Z

Makes sense to me.

ryanseys · 2015-03-05T20:27:45Z

stephenplusplus · 2015-03-10T18:05:04Z

2/3 todos done. Regarding the last one:

Add options.auto to apply a predefinedObjectACL on the bucket to allow new files to be created with the same permissions.

Should we just do this by default? Seems if I say "make my bucket private", it should shut people out until I re-open it (same logic in reverse as well).

ryanseys · 2015-03-10T19:20:37Z

I'd say yes for auto by default.

stephenplusplus · 2015-03-11T14:07:03Z

(saying that to myself)

lib/storage/bucket.js

+  async.parallel([
+    setPredefinedAcl,
+    addAclPermissions,
+    makeFilesPublic


stephenplusplus · 2015-03-23T19:03:58Z

PTAL!

lib/storage/bucket.js

+
+  function addAclPermissions(done) {
+    // Allow reading bucket contents while preserving original permissions.
+    self.acl.default.add({


ryanseys · 2015-03-23T20:41:41Z

🚢 it. (after tests pass)

…ivate allow making a bucket public/private

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/ba2d388f-b3b2-4ad7-a163-0c6b4d86894f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@05de3e1

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [null-loader](https://togithub.com/webpack-contrib/null-loader) | devDependencies | major | [`^3.0.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/null-loader/3.0.0/4.0.0) | --- ### Release Notes <details> <summary>webpack-contrib/null-loader</summary> ### [`v4.0.0`](https://togithub.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md#400-httpsgithubcomwebpack-contribnull-loadercomparev300v400-2020-04-15) [Compare Source](https://togithub.com/webpack-contrib/null-loader/compare/v3.0.0...v4.0.0) ##### Bug Fixes - support `webpack@5` ##### ⚠ BREAKING CHANGES - minimum required Nodejs version is `10.13` </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-video-intelligence).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9f8e7599-f87d-4fac-8f3a-a2e1781c33be/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 361273630 Source-Link: googleapis/googleapis@5477122

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [null-loader](https://togithub.com/webpack-contrib/null-loader) | devDependencies | major | [`^3.0.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/null-loader/3.0.0/4.0.0) | --- ### Release Notes <details> <summary>webpack-contrib/null-loader</summary> ### [`v4.0.0`](https://togithub.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md#400-httpsgithubcomwebpack-contribnull-loadercomparev300v400-2020-04-15) [Compare Source](https://togithub.com/webpack-contrib/null-loader/compare/v3.0.0...v4.0.0) ##### Bug Fixes - support `webpack@5` ##### ⚠ BREAKING CHANGES - minimum required Nodejs version is `10.13` </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-video-intelligence).

…429) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/0901f4c4-aa35-478b-ad7f-b996019d3c27/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@8cf6d28

* chore(main): release 4.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> Source-Author: F. Hinkelmann <[email protected]> Source-Date: Wed Sep 30 14:13:57 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 079dcce498117f9570cebe6e6cff254b38ba3860 Source-Link: googleapis/synthtool@079dcce

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2015

stephenplusplus added api: storage Issues related to the Cloud Storage API. don't merge labels Mar 5, 2015

stephenplusplus added this to the Storage Stable milestone Mar 5, 2015

stephenplusplus mentioned this pull request Mar 5, 2015

Add bucket#makePublic and bucket#makePrivate #418

Closed

stephenplusplus force-pushed the spp--bucket-makepublicprivate branch 2 times, most recently from c0ce479 to bd7b3e2 Compare March 10, 2015 18:01

stephenplusplus force-pushed the spp--bucket-makepublicprivate branch from bd7b3e2 to cadb6d6 Compare March 11, 2015 16:50

stephenplusplus reviewed Mar 11, 2015
View reviewed changes

stephenplusplus force-pushed the spp--bucket-makepublicprivate branch 2 times, most recently from b398773 to caea1d6 Compare March 23, 2015 19:02

allow making a bucket public/private

0d34f31

stephenplusplus force-pushed the spp--bucket-makepublicprivate branch from caea1d6 to 0d34f31 Compare March 23, 2015 19:03

stephenplusplus removed the don't merge label Mar 23, 2015

ryanseys reviewed Mar 23, 2015
View reviewed changes

lib/storage/bucket.js

function addAclPermissions(done) {

// Allow reading bucket contents while preserving original permissions.

self.acl.default.add({

This comment was marked as spam.

Sign in to view

remove old code

cd1f3e0

ryanseys added a commit that referenced this pull request Mar 23, 2015

Merge pull request #429 from stephenplusplus/spp--bucket-makepublicpr…

60f1ab2

…ivate allow making a bucket public/private

ryanseys merged commit 60f1ab2 into googleapis:master Mar 23, 2015

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

sofisl pushed a commit that referenced this pull request Nov 10, 2022

chore: add dev dependencies for cloud-rad ref docs (#429)

8ea2ca4

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-dataproc #3533

Merged

migrate code from googleapis/nodejs-monitoring #3545

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix: regen protos and tests, formatting (#429)

47ba866

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-containeranalysis #3550

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

build(node): update deps used during postprocessing (#1243) (#429)

c081610

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

docs: mention templates in contributing section of README (#429)

0eabab3

sofisl pushed a commit that referenced this pull request Jan 24, 2023

chore: release 3.3.0 (#429)

de79c96

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl pushed a commit that referenced this pull request Jan 25, 2023

chore: release 3.3.0 (#429)

6beb68d

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow making a bucket public/private #429

allow making a bucket public/private #429

stephenplusplus commented Mar 5, 2015

ryanseys commented Mar 5, 2015

stephenplusplus commented Mar 5, 2015

ryanseys commented Mar 5, 2015

stephenplusplus commented Mar 10, 2015

ryanseys commented Mar 10, 2015

stephenplusplus commented Mar 11, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Mar 23, 2015

This comment was marked as spam.

ryanseys commented Mar 23, 2015

allow making a bucket public/private #429

allow making a bucket public/private #429

Conversation

stephenplusplus commented Mar 5, 2015

bucket.makePublic([options], callback)

options

options.includeFiles

options.force

callback(error, [files])

bucket.makePrivate([options], callback)

options

options.strict

options.includeFiles

options.force

callback(error, [files])

Todos

Issues

ryanseys commented Mar 5, 2015

stephenplusplus commented Mar 5, 2015

ryanseys commented Mar 5, 2015

stephenplusplus commented Mar 10, 2015

ryanseys commented Mar 10, 2015

stephenplusplus commented Mar 11, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Mar 23, 2015

This comment was marked as spam.

ryanseys commented Mar 23, 2015