Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exponential backoff and retry certain requests #468

Merged
merged 1 commit into from
Mar 30, 2015
Merged

Exponential backoff and retry certain requests #468

merged 1 commit into from
Mar 30, 2015

Conversation

ryanseys
Copy link
Contributor

This should work. No regression tests because proof it works is our regression tests will no longer suffer from rate limit errors! 🙈

gcloud config now accepts: autoRetry: false (default: true) to turn off and maxRetries: 5 (default: 3) to change number of retries.

All retries are exponentially backed-off. That is:

1st retry: 1000-2000 ms delay
2nd retry: 2000-3000 ms delay
3rd retry: 4000-5000 ms delay (default: this is the last try by default)
4th retry: 8000-9000 ms delay
...

Fixes #460

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@ryanseys
Copy link
Contributor Author

PS I'm so excited for this! 🍭 🍬 💰

@stephenplusplus
Copy link
Contributor

This will go down as one of the best PRs gcloud has ever had.

stephenplusplus added a commit that referenced this pull request Mar 30, 2015
@stephenplusplus
Merge pull request #468 from ryanseys/rate-limits-RIP
eb3a63b 
Exponential backoff and retry certain requests
@stephenplusplus stephenplusplus merged commit eb3a63b into googleapis:master Mar 30, 2015
@ryanseys ryanseys deleted the rate-limits-RIP branch April 15, 2015 19:57
@sofisl sofisl mentioned this pull request Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
@SurferJeffAtGoogle @gcf-owl-bot
chore: migrate to owl bot (#468)
08f5a64 
* chore: migrate to owl bot

* chore: copy files from googleapis-gen fb91803ccef5d7c695139b22788b309e2197856b

* chore: run the post processor

* 🦉 Updates from OwlBot

* chore:add copyright

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@yoshi-automation
build: update docs and publish scripts (#468)
06a373e 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/4895db2c-aba9-406e-b81d-1e2251ee464c/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@5747555
Source-Link: googleapis/synthtool@bd0deaa
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
Update dependencies (#468)
3c203ac 
* Fix docs-samples tests, round 1

* Fix circle.yml

* Add RUN_ALL_BUILDS flag

* More container builder bugfixes

* Tweak env vars + remove manual proxy install

* Env vars in bashrc don't evaluate dynamically, so avoid them

* Add semicolons for command ordering

* Add appengine/static-files test to circle.yaml

* Fix failing container builder tests

* Address comments
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@yoshi-automation
build: update protos.js (#468)
db7cb1b 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/041f5df7-f5d3-4b2a-9ede-0752bf41c185/targets
sofisl pushed a commit that referenced this pull request Oct 12, 2022
Update dependencies (#468)
c299fba 
* Fix docs-samples tests, round 1

* Fix circle.yml

* Add RUN_ALL_BUILDS flag

* More container builder bugfixes

* Tweak env vars + remove manual proxy install

* Env vars in bashrc don't evaluate dynamically, so avoid them

* Add semicolons for command ordering

* Add appengine/static-files test to circle.yaml

* Fix failing container builder tests

* Address comments
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@yoshi-automation
fix: apache license URL (#468) (#308)
ee45c7f
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@release-please
chore: release 1.2.0 (#306)
7ca1834 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.2.0](https://www.github.com/googleapis/nodejs-resource/compare/v1.1.5...v1.2.0) (2020-05-20)


### Features

* Expose getIamPolicy support for project ([#302](https://www.github.com/googleapis/nodejs-resource/issues/302)) ([85f136d](https://www.github.com/googleapis/nodejs-resource/commit/85f136dfe133e42976864082cfe444a3f0cea37c))


### Bug Fixes

* apache license URL ([#468](https://www.github.com/googleapis/nodejs-resource/issues/468)) ([#308](https://www.github.com/googleapis/nodejs-resource/issues/308)) ([3fdebd3](https://www.github.com/googleapis/nodejs-resource/commit/3fdebd3b5f57d11dc77b8a6755d25d9be3da4794))
* **deps:** update dependency @google-cloud/common to v3 ([#301](https://www.github.com/googleapis/nodejs-resource/issues/301)) ([0ee3bf1](https://www.github.com/googleapis/nodejs-resource/commit/0ee3bf19810f38c4aa2a4e1b389022bc32bc70bc))
* **deps:** update dependency @google-cloud/paginator to v3 ([#299](https://www.github.com/googleapis/nodejs-resource/issues/299)) ([3cffb9f](https://www.github.com/googleapis/nodejs-resource/commit/3cffb9ffbdeaabd77522f17af9b5f25eb11a9009))
* **deps:** update dependency @google-cloud/promisify to v2 ([#298](https://www.github.com/googleapis/nodejs-resource/issues/298)) ([1e8965f](https://www.github.com/googleapis/nodejs-resource/commit/1e8965f204195d7d0014691dad6eb7d2efb632b9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@sofisl sofisl mentioned this pull request Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@sofisl
Update dependencies (#468)
0c212c3 
* Fix docs-samples tests, round 1

* Fix circle.yml

* Add RUN_ALL_BUILDS flag

* More container builder bugfixes

* Tweak env vars + remove manual proxy install

* Env vars in bashrc don't evaluate dynamically, so avoid them

* Add semicolons for command ordering

* Add appengine/static-files test to circle.yaml

* Fix failing container builder tests

* Address comments
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation @sofisl
build: update protos.js (#468)
75678d3 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/041f5df7-f5d3-4b2a-9ede-0752bf41c185/targets
sofisl pushed a commit that referenced this pull request Nov 9, 2022
@yoshi-automation
build: update docs and publish scripts (#468)
f4e39b2 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/4895db2c-aba9-406e-b81d-1e2251ee464c/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@5747555
Source-Link: googleapis/synthtool@bd0deaa
This was referenced Nov 9, 2022
Closed
Merged
sofisl pushed a commit that referenced this pull request Nov 10, 2022
Update dependencies (#468)
b999178 
* Fix docs-samples tests, round 1

* Fix circle.yml

* Add RUN_ALL_BUILDS flag

* More container builder bugfixes

* Tweak env vars + remove manual proxy install

* Env vars in bashrc don't evaluate dynamically, so avoid them

* Add semicolons for command ordering

* Add appengine/static-files test to circle.yaml

* Fix failing container builder tests

* Address comments
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@JustinBeckwith
refactor: drop dependency on is (#468)
34fd214
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@yoshi-automation
docs: spelling correction for "targetting" (#468)
3e41ca3 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/f9f34ae0-d83d-4c7a-a197-54a0a7255ebc/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@15013ef
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: Updating WORKSPACE files to use the newest version of the Typesc…
3342ca9 
…ript generator. (#468)

Also removing the explicit generator tag for the IAMPolicy mixin for the kms and pubsub APIS as the generator will now read it from the .yaml file.

PiperOrigin-RevId: 385101839

Source-Link: googleapis/googleapis@80f4042

Source-Link: googleapis/googleapis-gen@d3509d2
sofisl added a commit that referenced this pull request Sep 14, 2023
@sofisl
build: add auto-approve condition to test (#468)
93e5bb7 
* build: add auto-approve condition to test

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
@enterstudio enterstudio mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 28, 2023
Open
Open
Open
Open
@enterstudio enterstudio mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 28, 2023
Open
Open
Open
@enterstudio enterstudio mentioned this pull request Nov 28, 2023
Open
@takeratta takeratta mentioned this pull request Nov 29, 2023
Open
@enterstudio enterstudio mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
@takeratta takeratta mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
This was referenced Nov 30, 2023
Open
Open
Open
Open
@enterstudio enterstudio mentioned this pull request Dec 1, 2023
Open
@takeratta takeratta mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic retry request for all rate limit responses
3 participants
@ryanseys @stephenplusplus @googlebot