Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add external link - fixes #552 #592

Conversation

stephenplusplus
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2015
@stephenplusplus stephenplusplus added docs and removed cla: yes This human has signed the Contributor License Agreement. labels May 12, 2015
@jgeewax
Copy link
Contributor

jgeewax commented May 12, 2015

That looks awesome. Nice!

@ryanseys
Copy link
Contributor

Damn, that's neat. But it does look pretty cluttered. Can't we just set target="_blank" on all external links?

@stephenplusplus
Copy link
Contributor Author

I think this is just to denote that they are external links. Any ideas on how to de-clutter?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2015
@jgeewax
Copy link
Contributor

jgeewax commented May 12, 2015

Wait what exactly is cluttered? Are you saying the little external link icons are causing too much clutter? I'm seeing on average 1-2 per method, the occasional 3... I think it's useful to know when I'm leaving the docs...

@ryanseys
Copy link
Contributor

I think I just needed a minute to warm up to it. I was probably looking at a particularly cluttered area. Sorry for the false alarm.

@jgeewax
Copy link
Contributor

jgeewax commented May 13, 2015

Cool - LGTM.

stephenplusplus added a commit that referenced this pull request May 13, 2015
@stephenplusplus stephenplusplus merged commit 227d200 into googleapis:master May 13, 2015
sofisl pushed a commit that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [4.0.1](googleapis/nodejs-dataproc@v4.0.0...v4.0.1) (2022-06-20)


### Bug Fixes

* **deps:** update dependency @google-cloud/storage to v6 ([#592](googleapis/nodejs-dataproc#592)) ([54ffbec](googleapis/nodejs-dataproc@54ffbec))
* fixes for dynamic routing and streaming descriptors ([#591](googleapis/nodejs-dataproc#591)) ([3d1dc28](googleapis/nodejs-dataproc@3d1dc28))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-loader](https://togithub.com/TypeStrong/ts-loader) | devDependencies | major | [`^6.2.2` -> `^7.0.0`](https://renovatebot.com/diffs/npm/ts-loader/6.2.2/7.0.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-loader</summary>

### [`v7.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v700)

[Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v6.2.2...v7.0.0)

-   [Project reference support enhancements](https://togithub.com/TypeStrong/ts-loader/pull/1076) - thanks [@&#8203;sheetalkamat](https://togithub.com/sheetalkamat)!
-   Following the end of life of Node 8, `ts-loader` no longer supports Node 8 **BREAKING CHANGE**

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dialogflow).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put a little external-link icon next to links that take you away from the docs?
4 participants