Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version switcher dropdown #612

Conversation

stephenplusplus
Copy link
Contributor

Fixes #588

Preview: http://stephenplusplus.github.io/gcloud-node-gh-pages-again/#/docs/

screen shot 2015-05-19 at 3 33 10 pm

Got rid of the History view in favor of a dropdown. The dropdown and last built date are now in the sidebar. Let me know what ya think.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2015
@stephenplusplus stephenplusplus force-pushed the spp--docs-version-switcher-dropdown branch from 4e93c16 to 1565f58 Compare May 19, 2015 19:32
@ryanseys
Copy link
Contributor

I only see master when I try locally. Any reason why that could be happening?

@stephenplusplus
Copy link
Contributor Author

It's always been that way, because we don't carry the built json for all versions locally. To test, you can:

  1. clone gcloud-node under a different name (gcloud-node-gh-pages)
  2. switch to the gh-pages branch and git checkout -- versions.txt json
  3. switch back to my branch in your normal gcloud-node directory
  4. npm run docs
  5. cp -R docs/* ../gcloud-node-gh-pages

@ryanseys
Copy link
Contributor

Oooh, I found git checkout -- versions.txt json helped to do last after the cp -R but looks great! :)

ryanseys added a commit that referenced this pull request May 19, 2015
…er-dropdown

add version switcher dropdown
@ryanseys ryanseys merged commit 05af19d into googleapis:master May 19, 2015
@stephenplusplus
Copy link
Contributor Author

Oops :D Thanks!

@ryanseys
Copy link
Contributor

I noticed that the versions sit low on the page when in mobile mode due to being in the sidebar. This is certainly not ideal for mobile I think, but perhaps changing versions is not as important for mobile? Should we simply hide the version dropdown on mobile?

@stephenplusplus
Copy link
Contributor Author

It might be nice to move it up top in the smaller viewports. I would rather leave it where it is or move it up than remove it completely though.

@ryanseys
Copy link
Contributor

Can you move it up without moving the whole sidebar to the top?

@stephenplusplus
Copy link
Contributor Author

I’ll try :) I’m thinking a directive in two places, whose visibility toggles via CSS at the appropriate dimensions.

On May 19, 2015, at 5:22 PM, Ryan Seys [email protected] wrote:

Can you move it up without moving the whole sidebar to the top?


Reply to this email directly or view it on GitHub #612 (comment).

sofisl pushed a commit that referenced this pull request Nov 10, 2022
* chore(main): release 2.6.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
* fix: better support for fallback mode

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: accept google-gax instance as a parameter

Please see the documentation of the client constructor for details.

PiperOrigin-RevId: 470332808

Source-Link: googleapis/googleapis@d4a2367

Source-Link: googleapis/googleapis-gen@e97a1ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: use _gaxModule when accessing gax for bundling

PiperOrigin-RevId: 470911839

Source-Link: googleapis/googleapis@3527566

Source-Link: googleapis/googleapis-gen@f16a1d2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: do not fail if cleanup fails

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <[email protected]>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-dataproc@v4.0.1...v4.1.0) (2022-09-22)


### Features

* Add support for Dataproc metric configuration ([#626](googleapis/nodejs-dataproc#626)) ([79a4958](googleapis/nodejs-dataproc@79a4958))
* Support regapic LRO ([350626e](googleapis/nodejs-dataproc@350626e))


### Bug Fixes

* Allow passing gax instance to client constructor ([#612](googleapis/nodejs-dataproc#612)) ([caba80a](googleapis/nodejs-dataproc@caba80a))
* **deps:** Do not depend on protobufjs ([#607](googleapis/nodejs-dataproc#607)) ([4b62ef6](googleapis/nodejs-dataproc@4b62ef6))
* **deps:** Roll back dependency @google-cloud/dataproc to ^4.0.0 ([#627](googleapis/nodejs-dataproc#627)) ([e1c6d8b](googleapis/nodejs-dataproc@e1c6d8b))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-dataproc/issues/1553)) ([#617](googleapis/nodejs-dataproc#617)) ([2e2bea1](googleapis/nodejs-dataproc@2e2bea1))
* Preserve default values in x-goog-request-params header ([#620](googleapis/nodejs-dataproc#620)) ([484a023](googleapis/nodejs-dataproc@484a023))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 17, 2022
sofisl pushed a commit that referenced this pull request Jan 24, 2023
Source-Author: Stephen <[email protected]>
Source-Date: Wed Jun 17 14:16:18 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: b10590a4a1568548dd13cfcea9aa11d40898144b
Source-Link: googleapis/synthtool@b10590a
sofisl pushed a commit that referenced this pull request Jan 25, 2023
Source-Author: Stephen <[email protected]>
Source-Date: Wed Jun 17 14:16:18 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: b10590a4a1568548dd13cfcea9aa11d40898144b
Source-Link: googleapis/synthtool@b10590a
sofisl pushed a commit that referenced this pull request Sep 13, 2023
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the version history button a drop-down with all of the different versions to switch between
3 participants