-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce Logging support #865
Conversation
6fc0d0a
to
02f18aa
Compare
769488e
to
b782682
Compare
01fb9f7
to
5e7faac
Compare
6c68dba
to
b29cd90
Compare
@VikramTiwari - your thoughts are most welcome if you have the chance to play around with this! $ npm install --save stephenplusplus/gcloud-node#spp--logging |
Hey @stephenplusplus I am at Chrome Dev Summit for today and tomorrow, but I will be testing it by the end of week for sure. 👍 |
@VikramTiwari awesome! I'll look for you on the feed 🌠 |
b29cd90
to
4c8a3b6
Compare
@jgeewax to prepare for this to merge, can you check that the Logging API is enabled for the Travis project? |
Also, any ideas for getting Travis to auth as a user? Many of our system tests require user-level, non-service account auth. |
4c8a3b6
to
8ea3d82
Compare
8ea3d82
to
3100170
Compare
if (config.destination instanceof Dataset) { | ||
var dataset = config.destination; | ||
|
||
config.destination = format('{baseUrl}/projects/{pId}/datasets/{dId}', { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
delegate: process.env.user | ||
}); | ||
|
||
log.critical(entry, function(err) {}); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
9241a89
to
d154318
Compare
* | ||
* var config = { | ||
* destination: gcs.bucket('logging-bucket'), | ||
* filter: 'metadata.severity = ALERT' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
d154318
to
3c16414
Compare
* | ||
* @private | ||
*/ | ||
Logging.prototype.setAclForTopic_ = function(name, config, callback) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
3c16414
to
ac8fb21
Compare
* @return {string} | ||
*/ | ||
Log.formatName_ = function(projectId, name) { | ||
if (name.indexOf('logs/') > -1) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ac8fb21
to
22cd2a8
Compare
22cd2a8
to
e7e52a4
Compare
policy.bindings = arrify(policy.bindings); | ||
|
||
policy.bindings.push({ | ||
role: 'roles/editor', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
e7e52a4
to
ef51f55
Compare
introduce Logging support
Thanks @stephenplusplus! Also, thanks for the review @filipjs! |
🤖 I have created a release \*beep\* \*boop\* --- ### [4.3.1](https://www.github.com/googleapis/nodejs-dialogflow/compare/v4.3.0...v4.3.1) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#864](https://www.github.com/googleapis/nodejs-dialogflow/issues/864)) ([6646fb3](https://www.github.com/googleapis/nodejs-dialogflow/commit/6646fb35de95b2933adad91a4a111ee0dfd37ce9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #842
Must Reads
To Dos
Preview