Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: serviceobject#create: pass through any amount of arguments #938

Merged

Conversation

stephenplusplus
Copy link
Contributor

The ServiceObject was previously expecting precise arguments to a createSomething() callback:

service.createServiceObject(function(err, createdServiceObject, apiResponse) {});

That is almost always correct, except in the case of Compute Engine, which returns:

compute.createServiceObject(function(err, createdServiceObject, operation, apiResponse) {});

This updates the generic "create" method to consider that scenario.

@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. core labels Nov 11, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2015
callmehiphop added a commit that referenced this pull request Nov 11, 2015
…e-fix

core: serviceobject#create: pass through any amount of arguments
@callmehiphop callmehiphop merged commit c0ffbde into googleapis:master Nov 11, 2015
sofisl pushed a commit that referenced this pull request Nov 11, 2022
… type (#938)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 437265289

Source-Link: googleapis/googleapis@8e6b72f

Source-Link: googleapis/googleapis-gen@318cde2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzE4Y2RlMmVlM2JmZDViNDRhY2RmMWY2ZTI1YjhlMGE2NjZmMDc2NCJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. core type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants