storage: use default method options in File class #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
api: storage
googlebot
added
the
cla: yes
stephenplusplus
changed the title
| var requestQueryObject = {}; | ||
| var generation = parseInt(options.generation, 10); | ||
|
|
||
| if (generation) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Is the don't merge label here because of the previous PR dependency? Or is there still stuff to be done? |
stephenplusplus
force-pushed
the
spp--storage-file-use-default-method-options
branch
from
c466911
to
d464ad5
Compare
|
It was indeed! Switched to a strict number check. PTAL |
stephenplusplus
force-pushed
the
spp--storage-file-use-default-method-options
branch
from
d464ad5
to
a95853f
Compare
callmehiphop
added a commit
that referenced
this pull request
Nov 24, 2015
…fault-method-options storage: use default method options in File class
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Depends on #958 **
This removes some re-implemented methods that can, after #958 merges, be re-used from the ServiceObject class.