Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pubsub encoding option #988

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Add pubsub encoding option #988

merged 1 commit into from
Dec 3, 2015

Conversation

roberttod
Copy link
Contributor

As discussed in #987

  • UTF-8 conversion of binary data is not reversable
  • Use UTF-8 by default in order maintain current functionality

- UTF-8 conversion of binary data is not reversable
- Use UTF-8 by default in order maintain current functionality
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 3, 2015
@roberttod
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 3, 2015
@stephenplusplus
Copy link
Contributor

LGTM. Thanks very much! 👍 I'm hoping to have a release out soon. I'll give you a ping when it's out.

stephenplusplus added a commit that referenced this pull request Dec 3, 2015
@stephenplusplus stephenplusplus merged commit f87a55c into googleapis:master Dec 3, 2015
@roberttod
Copy link
Contributor Author

Thanks for merging!

@roberttod roberttod deleted the pubsub-encoding-option branch December 4, 2015 11:03
@jgeewax
Copy link
Contributor

jgeewax commented Dec 4, 2015

/cc @quartzmo @blowmage : Do we need to do likewise in Ruby?
/cc @dhermes @tseaver : Do we need to do likewise in Python?

@tseaver
Copy link

tseaver commented Dec 4, 2015

@jgeewax gcloud-python base64-encodes the message payload, per https://cloud.google.com/pubsub/publisher#publish.

@blowmage
Copy link
Contributor

blowmage commented Dec 4, 2015

We will investigate if this is needed in gcloud-ruby. Ruby string have encoding attributes, so a non-UTF-8 string shouldn't be converted to UTF-8 before/after encoding to base64. But we haven't tested any binary so we will make sure it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants