-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pubsub encoding option #988
Add pubsub encoding option #988
Conversation
- UTF-8 conversion of binary data is not reversable - Use UTF-8 by default in order maintain current functionality
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
LGTM. Thanks very much! 👍 I'm hoping to have a release out soon. I'll give you a ping when it's out. |
Add pubsub encoding option
Thanks for merging! |
@jgeewax |
We will investigate if this is needed in gcloud-ruby. Ruby string have encoding attributes, so a non-UTF-8 string shouldn't be converted to UTF-8 before/after encoding to base64. But we haven't tested any binary so we will make sure it works. |
As discussed in #987