Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query paramters need to coerce native Python values #2799

Closed
tseaver opened this issue Dec 2, 2016 · 0 comments
Closed

Query paramters need to coerce native Python values #2799

tseaver opened this issue Dec 2, 2016 · 0 comments
Assignees
@tseaver
Labels
api: bigquery Issues related to the BigQuery API.

Comments

@tseaver
Copy link
Contributor

tseaver commented Dec 2, 2016

If the user passes in non-string values (e.g., for INT64, which must be tunnelled via strings because JS reasons, or TIMESTAMP, DATETIME, DATE), the parameter must coerce the value appropriately inside its to_api_repr() method.

h/t to @dwsupplee for the prod.
@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Dec 2, 2016
@tseaver tseaver self-assigned this Dec 2, 2016
@tseaver tseaver mentioned this issue Dec 3, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this issue May 6, 2017
@tseaver
Coerce query paramter values from native types to JSON-appropriate ty…
22249c3 
…pes.

Also, distingush parsing 'DATETIME' vs. 'TIMESTAMP' properly when
processing row data.

Closes googleapis#2799.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tseaver