Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner should know how to merge chunk data of TIMESTAMP and DATE type #3981

Closed
yixizhang opened this issue Sep 15, 2017 · 1 comment
Closed

Spanner should know how to merge chunk data of TIMESTAMP and DATE type #3981

yixizhang opened this issue Sep 15, 2017 · 1 comment
Assignees
@tseaver
Labels
api: spanner Issues related to the Spanner API.

Comments

@yixizhang
Copy link

yixizhang commented Sep 15, 2017 •
edited
Loading

https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/spanner/google/cloud/spanner/streamed.py#L300

The dict doesn't cover type_pb2.TIMESTAMP and type_pb2.DATE, the fix is actually easy because both type is passed in string_value.
@vkedia
Copy link

vkedia commented Sep 16, 2017

Thanks for filing this. This indeed looks like a bug.
@tseaver @lukesneeringer please take a look.

@vkedia vkedia mentioned this issue Sep 19, 2017
Closed
lukesneeringer pushed a commit to lukesneeringer/google-cloud-python that referenced this issue Sep 21, 2017
Merge dates and timestamps properly.
e1506e0 
Fixes googleapis#3981
Fixes googleapis#3998
Closes googleapis#4009
@lukesneeringer lukesneeringer mentioned this issue Sep 21, 2017
Merged
@tseaver tseaver added the api: spanner Issues related to the Spanner API. label Sep 21, 2017
tseaver pushed a commit that referenced this issue Sep 21, 2017
@lukesneeringer @tseaver
Merge dates and timestamps properly. (#4015)
1b9edf9 
Fixes #3981
Fixes #3998
Closes #4009
This was referenced Sep 22, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yixizhang @tseaver @vkedia