Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing get_for_service_account_* helpers. #1513

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 20, 2016

After oauth2client 2.0.0 the are just thin wrappers around factory constructors, so no longer needed.

Note that gcloud.credentials.get_credentials() is also a very thin wrapper, however, it has useful documentation.


@tseaver Do you think I should also remove get_credentials() and try to push to documentation into oauth2client? (I need to do a side-by-side, I can't quite remember the state of things.)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2016
After oauth2client 2.0.0 the are just thin wrappers around
factory constructors, so no longer needed.

Note that gcloud.credentials.get_credentials() is also a
very thin wrapper, however, it has useful documentation.
@jgeewax
Copy link
Contributor

jgeewax commented Feb 21, 2016

I get the feeling that there should be some documentation changes here, right ?

What I want to make sure we avoid is the whole thing of saying "Oh you want to do auth? Yea,... go over here.... we don't care enough to tell you how to do it..."

I'm fine with not wrapping simple APIs, but we still need to clarify those APIs so that people can use them without digging through code of oauth2client ... right ?

@dhermes
Copy link
Contributor Author

dhermes commented Feb 21, 2016

These helpers have never been part of our documentation, but we also don't have a "we don't care enough to tell you how to do it" attitude either. The auth page encourages using the Client.from_service_account_json or Client.from_service_account_p12 factories.

You can confirm the lack of references to these helpers via git grep get_for_service_account_ (no results).

@theacodes
Copy link
Contributor

This LGTM.

dhermes added a commit that referenced this pull request Feb 23, 2016
Removing get_for_service_account_* helpers.
@dhermes dhermes merged commit 9c4807d into googleapis:master Feb 23, 2016
@dhermes dhermes deleted the remove-svc-acct-wrappers branch February 23, 2016 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core auth cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants