Completing Bigtable cluster admin API system tests. #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -93,3 +93,59 @@ def test_list_clusters(self): | |||
| cluster_existence = (cluster in EXISTING_CLUSTERS or | |||
| cluster == Config.CLUSTER) | |||
| self.assertTrue(cluster_existence) | |||
|
|
|||
| def test_reload(self): | |||
| # Use same arguments as Config.CLUSTER (created in `setUpModule`). | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
bigtable-cluster-api-sys-tests
branch
from
004ee11
to
b3ca070
Compare
|
@jonparrott PTAL |
|
|
||
| # We want to make sure the operation completes. | ||
| time.sleep(2) | ||
| self.assertTrue(operation.finished()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jonparrott PTAL |
|
LGTM. Don't forget to |
|
Ha! |
dhermes
force-pushed
the
bigtable-cluster-api-sys-tests
branch
from
3c88a65
to
4ca6b93
Compare
dhermes
added a commit
that referenced
this pull request
Feb 24, 2016
Completing Bigtable cluster admin API system tests.
|
After deleting the branch on GH I pruned the remote locally
|
|
Brilliant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.