Adding virtual implementations for remaining HappyBase Table methods. #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -97,7 +97,7 @@ class Connection(object): | |||
|
|
|||
| The arguments ``host``, ``port``, ``compat``, ``transport`` and | |||
| ``protocol`` are allowed (as keyword arguments) for compatibility with | |||
| HappyBase. However, they will not be used in anyway, and will cause a | |||
| HappyBase. However, they will not be used in any way, and will cause a | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Cool, this is helpful. LGTM, but with minor concern about that import. |
dhermes
added a commit
that referenced
this pull request
Feb 24, 2016
Adding virtual implementations for remaining HappyBase Table methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonparrott I figured this would be good for you to get a sense of why I'd be sending PRs for helpers before actually implementing the methods themselves. The helpers themselves contain quite a bit of code (HappyBase is a nice abstraction and the work is worth it).