Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HappyBase Batch.put() and helpers. #1533

Merged
merged 2 commits into from
Feb 25, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 25, 2016

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 25, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2016
@@ -133,3 +191,54 @@ def __exit__(self, exc_type, exc_value, traceback):
# NOTE: For non-transactional batches, this will even commit mutations

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@theacodes
Copy link
Contributor

LGTM, with slight nit

@dhermes
Copy link
Contributor Author

dhermes commented Feb 25, 2016

@jonparrott I'm going to merge now (a HappyBase table helper relies on _get_column_pairs). If not note in the Batch docstring is insufficient LMK and I can iterate on it.

dhermes added a commit that referenced this pull request Feb 25, 2016
Adding HappyBase Batch.put() and helpers.
@dhermes dhermes merged commit 8b49f25 into googleapis:master Feb 25, 2016
@dhermes dhermes deleted the happybase-batch-put branch February 25, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants