Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helpful documentation to HappyBase package init. #1545

Merged
merged 2 commits into from
Feb 26, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 26, 2016

No description provided.

@dhermes dhermes added docs api: bigtable Issues related to the Bigtable API. labels Feb 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2016
- tables in Cloud Bigtable do not expose internal storage details
* :meth:`Table.counter_set() \
<gcloud.bigtable.happybase.table.Table.counter_set>` - method can't
be atomic, so we disable it

This comment was marked as spam.

@theacodes
Copy link
Contributor

This looks great, with one tiny comment.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 26, 2016

When I originally wrote this MutateRows did not exist so I had a bullet with

* The ``batch_size`` attribute in :class:`.Batch` cannot be truly mapped
  from HBase to Cloud Bigtable. The main reason for this is that the Cloud
  Bigtable API can only send mutations for a single row (via ``MutateRow``,
  ``CheckAndMutateRow``, and ``ReadModifyWriteRow``) whereas HBase sends
  all mutations at once. This requires a single request to be sent for each
  mutated row in the batch. This should not be noticeable since gRPC
  uses HTTP/2. However, some of the requests may fail part way through and
  the process of applying all mutations cannot be rolled back.

Now I need to implement the support for it. Exciting to see missing features appear! Filed #1546

@theacodes
Copy link
Contributor

Glad to see that's possible, as that would be pretty surprising behavior.

be atomic, so we disable it
* The ``__version__`` value for the HappyBase package is :data:`None`.
However, it's worth nothing this implementation was based off HappyBase
0.9.

This comment was marked as spam.

This comment was marked as spam.

dhermes added a commit that referenced this pull request Feb 26, 2016
Adding helpful documentation to HappyBase package init.
@dhermes dhermes merged commit 4c1c2c1 into googleapis:master Feb 26, 2016
@dhermes dhermes deleted the happy-base-init-docs branch February 26, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants