Allow unit tests to pass if pytz is installed.

[rimey]

I'm assuming the intent of test_module_property() is
to check that gcloud._helpers.UTC is defined and has
the right sort of value. It was failing if pytz
happened to be installed.

Note that the current test environment does not
install pytz. The gcloud package uses pytz if it is
available but does not depend on it.

[tseaver]

Thanks for the patch! ISTM that a better fix for the test would be to have it try to import pytz and DTRT depending on success. E.g.:

    def test_module_property(self):
        from gcloud import _helpers as MUT
        klass = self._getTargetClass()
        try:
            import pytz
        except ImportError:
            self.assertTrue(isinstance(MUT.UTC, klass))
        else:
            self.assertTrue(MUT.UTC is pytz.UTC)

[rimey]

Done. PTAL.

[tseaver]

Thanks very much!

[dhermes]

Why do we no cover both branches?

[rimey]

Only one is executed in any given test environment. Did I understand your
question correctly?

On Fri, Apr 8, 2016 at 11:48 AM, Danny Hermes [email protected]
wrote:

Why do we no cover both branches?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1706 (comment)

[dhermes]

But the relevant coverage environment, i.e. the one that get's reported on our repo (from coveralls.io) use the tox cover environment. We should have that branch without a no cover pragma.

[rimey]

I guess the idea is that the test code will do the right thing in any
reasonable environment, while the coverage pragmas on that test code will
be correct for the tox cover environment? I can send another pull request.

On Fri, Apr 8, 2016 at 11:55 AM, Danny Hermes [email protected]
wrote:

But the relevant coverage environment, i.e. the one that get's reported on
our repo (from coveralls.io) use the tox cover environment. We should
have that branch without a no cover pragma.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1706 (comment)

[dhermes]

Thanks for sending the PR!