Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #141: remove spurious *args / **kwargs from API methods. #195

Closed
wants to merge 32 commits into from
Closed

Fix #141: remove spurious *args / **kwargs from API methods. #195

wants to merge 32 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 26, 2014

No description provided.

tseaver and others added 18 commits September 24, 2014 17:27
@tseaver
Fix #133: preserve PB namespace in Key.from_protobuf.
a7e8864
@tseaver
Add docstrings for API method of g.datastore.key.Key.
a077d7d
@tseaver
Fix #134: enforce contract that *args must be pairs.
0e625da
@tseaver
Propose a contract for Key.parent.
fe1450b
@tseaver
Fix #135: enforce contract for Key.parent().
c8f6aa4
@tseaver
Incorporate feedback from @dhermes.
f107fda
@tseaver
Merge branch 'add_key_docstrings' into 133-key.from_protobuf-preserve…
7076c4d 
…-namespace
@tseaver
Merge branch 'add_key_docstrings' into 134-key-from_path-contract
19c6382
@tseaver
Merge branch 'add_key_docstrings' into 135-key-parent-contract
4500f5e
@tseaver
Incorporate feedback from @dhermes.
37dd328
@tseaver
Incorporate feedback from @dhermes.
d1280f3
@tseaver
Merge branch 'add_key_docstrings' into 135-key-parent-contract
8ce18c9
@tseaver
Fix #137: default key based on filename.
e6ad297 
When no key is passed, guess it based on the basename of filename.
@tseaver
Fix #138: clear existing (local) ACL when saving ACL to server.
fb756b2
Added bucket method to upload files from a file object.
2f93065
@tseaver
Fix #139: clear existing (local) ACL when saving defaultObjectACL to …
e19cf86 
…server.
@tseaver
Fix #140: make 'path' required for Connection.api_request.
ccd8a5e
@tseaver
Fix #141: remove spurious *args / **kwargs from API methods.
e346282
dhermes
dhermes reviewed Sep 27, 2014
View reviewed changes
gcloud/storage/test_bucket.py
@@ -648,7 +648,7 @@ def test_save_default_object_acl_existing_set_new_passed(self):
bucket = self._makeOne(connection, NAME, metadata)
bucket.reload_default_object_acl()
self.assertTrue(bucket.save_default_object_acl(new_acl) is bucket)
# See: https://github.com/GoogleCloudPlatform/gcloud-python/issues/138
# See: https://github.com/GoogleCloudPlatform/gcloud-python/issues/139

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Sep 27, 2014

LGTM after small docfix in docs/storage-getting-started.rst

Which PR does 1823b0f actually belong in?

Can you get rid of it and rebase/cherry-pick e346282? Let's avoid slipping in little things not related to the PR.

@dhermes
Copy link
Contributor

dhermes commented Sep 27, 2014

LGTM, rebase and then we can merge?

@silvolu
Merge pull request #184 from tseaver/add_key_docstrings
0a5fe6b 
Add docstrings for API method of g.datastore.key.Key.
@silvolu
Merge pull request #198 from dhermes/datastore-cnxn-inherit-generic
5c3d8ae 
Making datastore.connection.Connection inherit from base Connection.
@silvolu
Merge pull request #145 from kleyow/files
62e887d 
Added bucket method to upload files from a file object.
@silvolu
Merge pull request #191 from tseaver/137-upload_file-guess_key_based_…
60887ab 
…on_filename

Fix #137:  default key based on filename.
@silvolu
Merge pull request #192 from tseaver/138-save_acl-clear_existing_loca…
23fc80f 
…l_acl

Fix #138: clear existing (local) ACL when saving ACL to server.
@silvolu
Merge pull request #193 from tseaver/139-save_default_object_acl-clea…
d8b4e36 
…r_existing_local_acl

Fix #139: clear existing (local) ACL when saving defaultObjectACL to server
parthea added a commit that referenced this pull request Aug 15, 2023
@parthea @gcf-owl-bot
chore: add default_version and codeowner_team to .repo-metadata.json (#…
4b62fe1 
…195)

* chore: add default_version and codeowner_team to .repo-metadata.json

* update default_version

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Aug 15, 2023
@release-please @parthea
chore(main): release 2.6.2 (#195)
fef4029 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 14, 2023
@gcf-owl-bot
chore(python): exclude path in renovate.json [autoapprove] (#195)
6303519 
Source-Link: googleapis/synthtool@69fabae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
docs: users can self enroll retail search feature on cloud console (#195
1096a28 
)

* docs: users can self enroll retail search feature on cloud console
docs: suggest search users not to send IP and use hashed user id
docs: deprecate request_id in ImportProductsRequest
docs: deprecate search dynamic_facet_spec and suggest to config on cloud console
docs: keep the API doc up-to-date with recent changes
feat: add new AddLocalInventories and RemoveLocalInventories APIs
feat: users cannot switch to empty default branch unless force override
feat: allow search users to skip validation for invalid boost specs
feat: support search personalization
feat: search returns applied control ids in the response

PiperOrigin-RevId: 437355889

Source-Link: googleapis/googleapis@4d00815

Source-Link: googleapis/googleapis-gen@b2b7982
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJiNzk4MjQ3ZDQ2YzkzMjczN2NmNjg5NzQ0YTgyN2ZhZTdlNTMxMyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 20, 2023
@parthea
fix(deps): require protobuf <4.0.0dev (#195)
3cb74c7
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@danoscarmike
chore: adds description, long_description (#195)
36a9927
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): add license header to auto-label.yaml (#195)
cd0637c 
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update dependency google-cloud-bigquery to v2.24.0 (#195)
1290128 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-testutils to v1.3.1 (#195)
32a0b6c
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.10.4 (#195)
1dc1608 
🤖 I have created a release *beep* *boop*
---


### [2.10.4](googleapis/python-container@v2.10.3...v2.10.4) (2022-02-14)


### Bug Fixes

* **deps:** move libcst to extras ([#194](googleapis/python-container#194)) ([1c308c2](googleapis/python-container@1c308c2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-auth to v1.30.1 (#195)
5477ad4
parthea pushed a commit that referenced this pull request Sep 22, 2023
@dandhlee
chore: update doc links from googleapis.dev to cloud.google.com (#195)
6851470
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
build: use trampoline_v2 for python samples and allow custom dockerfi…
6cd8b67 
…le (#195)

Source-Link: googleapis/synthtool@a7ed11e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-videointelligence to v2.3…
7b47419 
….2 (#195)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): exclude setup.py in renovate config (#195)
289d289 
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: new owl bot post processor docker image (#195)
86d75b2 
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:0856ca711da1fd5ec9d6d7da6c50aa0bbf550fb94acb47b55159a640791987bf

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency grafeas to v1.2.0 (#195)
b6649ff
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
docs: Minor formatting (#195)
db510b9 
* docs: Minor formatting
chore: Update gapic-generator-python to v1.11.5
build: Update rules_python to 0.24.0

PiperOrigin-RevId: 563436317

Source-Link: googleapis/googleapis@42fd37b

Source-Link: googleapis/googleapis-gen@280264c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: add support for Raw PKCS#1 signing keys (#195)
29aaf20 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 403966825

Source-Link: googleapis/googleapis@5b0219d

Source-Link: googleapis/googleapis-gen@ea0000e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWEwMDAwZTcwOGU4NjBiNjViNTc0NzgzZDVlYTYxYWQzNDA5MTFiZSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore: release 2.10.0 (#196)
ea7883a 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.10.0](https://www.github.com/googleapis/python-kms/compare/v2.9.0...v2.10.0) (2021-10-18)


### Features

* add support for Raw PKCS[#1](https://www.github.com/googleapis/python-kms/issues/1) signing keys ([#195](https://www.github.com/googleapis/python-kms/issues/195)) ([9c4f997](https://www.github.com/googleapis/python-kms/commit/9c4f997d09e9a83141eda767cd2bb63a0bf58a37))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
chore: require CODEOWNER review and up to date branches (#195)
41a6f3c 
These two lines bring the rules on this repo in line with the defaults:

https://github.com/googleapis/repo-automation-bots/blob/63c858e539e1f4d9bb8ea66e12f9c0a0de5fef55/packages/sync-repo-settings/src/required-checks.json#L40-L50
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v1.41.0 (#195)
a082f3a 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-storage](https://togithub.com/googleapis/python-storage) | `==1.40.0` -> `==1.41.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.41.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.41.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.41.0/compatibility-slim/1.40.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.41.0/confidence-slim/1.40.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-storage</summary>

### [`v1.41.0`](https://togithub.com/googleapis/python-storage/blob/master/CHANGELOG.md#&#8203;1410-httpswwwgithubcomgoogleapispython-storagecomparev1400v1410-2021-07-13)

[Compare Source](https://togithub.com/googleapis/python-storage/compare/v1.40.0...v1.41.0)

##### Features

-   add support for Etag headers on reads ([#&#8203;489](https://www.github.com/googleapis/python-storage/issues/489)) ([741d3fd](https://www.github.com/googleapis/python-storage/commit/741d3fda4e4280022cede29ebeb7c2ea09e73b6f))

##### Bug Fixes

-   **deps:** update minimum dependency versions to pick up bugfixes ([#&#8203;496](https://www.github.com/googleapis/python-storage/issues/496)) ([92251a5](https://www.github.com/googleapis/python-storage/commit/92251a5c8ea4d663773506eb1c630201a657aa69)), closes [#&#8203;494](https://www.github.com/googleapis/python-storage/issues/494)
-   populate etag / generation / metageneration properties during download ([#&#8203;488](https://www.github.com/googleapis/python-storage/issues/488)) ([49ba14c](https://www.github.com/googleapis/python-storage/commit/49ba14c9c47dbe6bc2bb45d53bbe5621c131fbcb))
-   revise and rename is_etag_in_json(data) ([#&#8203;483](https://www.github.com/googleapis/python-storage/issues/483)) ([0a52546](https://www.github.com/googleapis/python-storage/commit/0a5254647bf1155874fe48f3891bcc34a76b0b81))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-vision).
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: remove WebDataStream, IosAppDataStream, `AndroidAppDataStre…
9d4498f 
…am` resources (#195)

- [ ] Regenerate this pull request now.

feat: add `restricted_metric_type` field to the `CustomMetric` resource
feat: move the `GlobalSiteTag` resource from the property level to the data stream level

PiperOrigin-RevId: 432342398

Source-Link: googleapis/googleapis@a079cb0

Source-Link: googleapis/googleapis-gen@2f29c5a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmYyOWM1YWYzMDU0YTZlMzhkZjIxNThmMDliNzZlYzJmYWZkMGIyZiJ9

Closes #184
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: update copyright year to 2022 (#195)
e872b8d 
* chore: update copyright year to 2022

PiperOrigin-RevId: 431037888

Source-Link: googleapis/googleapis@b3397f5

Source-Link: googleapis/googleapis-gen@510b54e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): add support for python 3.11 (#195)
cd0a4e5 
Source-Link: googleapis/synthtool@7197a00
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): Update cloudbuild BUILD.bazel package name to google-c…
4063ff2 
…loud-build chore(python): Update cloudbuild namespace to google.cloud.devtools (#195)

* chore(python): Update cloudbuild BUILD.bazel package name to google-cloud-build chore(python): Update cloudbuild namespace to google.cloud.devtools

PiperOrigin-RevId: 406424368

Source-Link: googleapis/googleapis@a83e6f2

Source-Link: googleapis/googleapis-gen@e57389e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTU3Mzg5ZThkNjRlNzM1NTUyYzRmNDgyNmMyYjZkMGYwZWNjM2Q1MiJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore(python): exclude path in renovate.json [autoapprove] (#195)
660194b 
Source-Link: googleapis/synthtool@69fabae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387
parthea added a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot @parthea
fix: require python 3.7+ (#195)
2600ff5 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* add api_description to .repo-metadata.json

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* exclude templated readme

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot @parthea
chore: Update gapic-generator-python to v1.8.5 (#195)
78ff882 
* chore: Update gapic-generator-python to v1.8.5

PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@release-please
chore(main): release 1.6.1 (#195)
f1f5287 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @silvolu @beriberikix