Fixed a majority of pep8 errors in gcloud.

[kleyow]

No description provided.

[dhermes]

I should run pep8 with 2 indents, i.e. pep8 --ignore=E111 gcloud/connection.py?

[dhermes]

$ pep8 --ignore=E111 gcloud/datastore/demo/__init__.py 
gcloud/datastore/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)
$ pep8 --ignore=E111 gcloud/datastore/entity.py 
gcloud/datastore/entity.py:46:80: E501 line too long (86 > 79 characters)
gcloud/datastore/entity.py:51:80: E501 line too long (83 > 79 characters)
gcloud/datastore/entity.py:58:80: E501 line too long (84 > 79 characters)
gcloud/datastore/entity.py:71:80: E501 line too long (82 > 79 characters)
gcloud/datastore/entity.py:119:80: E501 line too long (88 > 79 characters)
gcloud/datastore/entity.py:124:80: E501 line too long (85 > 79 characters)
gcloud/datastore/entity.py:138:80: E501 line too long (101 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/acl.py 
gcloud/storage/acl.py:382:80: E501 line too long (81 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/bucket.py 
gcloud/storage/bucket.py:105:80: E501 line too long (81 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/connection.py 
gcloud/storage/connection.py:467:80: E501 line too long (80 > 79 characters)
gcloud/storage/connection.py:479:80: E501 line too long (93 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/demo/__init__.py 
gcloud/storage/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/iterator.py 
gcloud/storage/iterator.py:149:80: E501 line too long (91 > 79 characters)
gcloud/storage/iterator.py:177:80: E501 line too long (85 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/key.py 
gcloud/storage/key.py:98:80: E501 line too long (81 > 79 characters)
gcloud/storage/key.py:211:9: E123 closing bracket does not match indentation of opening bracket's line
gcloud/storage/key.py:235:11: E123 closing bracket does not match indentation of opening bracket's line
$ pep8 --ignore=E111 gcloud/storage/test_bucket.py 
gcloud/storage/test_bucket.py:353:80: E501 line too long (80 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/test_connection.py 
gcloud/storage/test_connection.py:158:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:173:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:189:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:209:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:226:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:276:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:296:44: E241 multiple spaces after ':'

[dhermes]

To fix the indents, I have been testing out a combination of pep8ify and my own solution for indenting doscstrings (which pep8ify, pyfmt and other auto-format libraries fail on).

I am happy to continue that effort after this commit gets checked in.

We also want to pass pylint, as that checks code style in addition to syntax. We can discuss that more in #179

[dhermes]

I ran git ls-files gcloud*py and there were 13 Python files, not included in this commit.

Nine of them check out just fine:

gcloud/__init__.py
gcloud/credentials.py
gcloud/datastore/demo/__main__.py
gcloud/datastore/demo/demo.py
gcloud/datastore/helpers.py
gcloud/datastore/transaction.py
gcloud/demo.py
gcloud/storage/exceptions.py
gcloud/storage/test_exceptions.py

However, the following errors were detected:

$ pep8 --ignore=E111 gcloud/datastore/connection.py
gcloud/datastore/connection.py:76:9: E123 closing bracket does not match indentation of opening bracket's line
gcloud/datastore/connection.py:159:80: E501 line too long (81 > 79 characters)
gcloud/datastore/connection.py:229:80: E501 line too long (88 > 79 characters)
$ pep8 --ignore=E111 gcloud/datastore/query.py
gcloud/datastore/query.py:50:7: E123 closing bracket does not match indentation of opening bracket's line
gcloud/datastore/query.py:66:80: E501 line too long (93 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/demo/__init__.py
gcloud/storage/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)

In addition, the file gcloud/datastore/datastore_v1_pb2.py is all kinds of messed up, but I presume we should leave it as-is. We should consider using a .gitattributes file to check it in as binary and also in #178 we should ignore this file in a programmatic PEP/pylint check.

[tseaver]

@dhermes definitely leave the generated 'datastore_v1_pb2.py' as-is.

[tseaver]

We need to debate / document the style guide (by reference / delta to whatever authoritative specs we choose), and then automate testing of them (e.g., via something like 'tox -e lint', including automating exceptions).

[dhermes]

RE: automation, I checked out this branch and tested every .py file with pep8 --ignore=E111. If @kleyow likes, we can do the whitespace fixes here too, or I'm happy to do it with pep8ify and my custom docstring indent script.

In addition to passing pep8 <file> I'd like to have our files pass pylint --reports=n without any warnings or errors.

[kleyow]

@dhermes Go ahead and do it with your script. Yep sounds good.

[dhermes]

@kleyow Since you've already done a bulk of the work, let's check this in and then I can tackle the rest with the automated tools.

You can ignore the two files left out: gcloud/storage/demo/__init__.py and gcloud/datastore/connection.py but can you try to resolve the issues in existing files?

@tseaver Does this sound good?

[kleyow]

Whoops misclicked, issues were fixed in kleyow@b8a989f

[kleyow]

Should I switch to

 headers = {
         'Content-Type': 'application/x-protobuf',
         'Content-Length': str(len(data)),
     }

in this ticket.

[dhermes]

Yes please do. Also run pep8 --ignore=E111 on each of the files to make sure they have no issues.