Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 2.6. #2051

Merged
merged 6 commits into from
Aug 4, 2016
Merged

Drop support for Python 2.6. #2051

merged 6 commits into from
Aug 4, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 3, 2016

Closes #1607.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2016
@dhermes
Copy link
Contributor

dhermes commented Aug 3, 2016

I'm grep-ing around for some other things worth cleaning up:

CONTRIBUTING.rst:- The feature must work fully on the following CPython versions: 2.6,
CONTRIBUTING.rst:-  `Python 2.6`_
CONTRIBUTING.rst:.. _Python 2.6: https://docs.python.org/2.6/
CONTRIBUTING.rst:We may `drop 2.6`_ as a supported version as well since Python 2.6 is no
CONTRIBUTING.rst:.. _drop 2.6: https://github.com/GoogleCloudPlatform/gcloud-python/issues/995
gcloud/_helpers.py:363:    if sys.version_info[:2] < (2, 7):  # pragma: NO COVER Python 2.6
gcloud/exceptions.py:40:        # suppress deprecation warning under 2.6.x
gcloud/error_reporting/client.py:174:            # once py26 support is dropped this can use dict comprehension

@tseaver
Copy link
Contributor Author

tseaver commented Aug 4, 2016

@dhermes Should be addressed in subsequent commits.

@tseaver
Drop Python 2.6 helper function.
5edab4b 
'gcloud._helpers._total_seconds' worked around the fact that
'datetime.timedelta.total_seconds' was not added until Python 2.7.
@tseaver
Drop Python 2.6 workaround.
8f84ea0
@tseaver
Use a dict comprehension.
d8aa805
@tseaver
Copy link
Contributor Author

tseaver commented Aug 4, 2016

Amended to fix the lint issue.

dhermes
dhermes reviewed Aug 4, 2016
View reviewed changes
gcloud/exceptions.py
@@ -36,8 +36,7 @@ class GCloudError(Exception):
"""

def __init__(self, message, errors=()):
super(GCloudError, self).__init__()
# suppress deprecation warning under 2.6.x
super(GCloudError, self).__init__(message)
self.message = message

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Aug 4, 2016

Only question left: do we want to add a warning on import?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 4, 2016

Do we want to add a warning on import?

I think not on import: maybe on installation. @daspecster, @jgeewax WDYT?

@dhermes
Copy link
Contributor

dhermes commented Aug 4, 2016

OK let's just merge (LGTM) and file an issue to follow up / decide if we should warn on either import or installation.

@tseaver tseaver merged commit 3328a5c into googleapis:master Aug 4, 2016
@tseaver tseaver deleted the drop-py26 branch August 4, 2016 18:15
@tseaver tseaver mentioned this pull request Aug 4, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Aug 4, 2016

See also #2056.

@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @daspecster @googlebot