Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model/parse 'job.cancel' API response correctly. #2379

Merged
merged 3 commits into from
Sep 22, 2016
Merged

Model/parse 'job.cancel' API response correctly. #2379

merged 3 commits into from
Sep 22, 2016

Commits on Sep 21, 2016

  1. Model/parse 'job.cancel' API response correctly. 

    Closes #2377.
    @tseaver
    tseaver committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    5443e14 View commit details
    Browse the repository at this point in the history

  2. Add a system test for '_AsyncJob.cancel'.

    @tseaver
    tseaver committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    b3f130a View commit details
    Browse the repository at this point in the history

  3. Replace redundant 'job done' assertion with a note. 

    Explain why we can't make any real assertions about the status of the
cancelled job.

Addresses:
#2379 (comment).
    @tseaver
    tseaver committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    14b8cc4 View commit details
    Browse the repository at this point in the history