-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR 2336 and upgrade to google-gax>=0.14.1 #2388
Conversation
This reverts commit b185ee8.
This reverts commit f916093.
In the process, adding back code changes that were reverted in the process of reverting PR googleapis#2336. Some of the changes were necessary, but anything using GAX (logging and pubsub) could safely be restored.
Is |
@daspecster I'm not sure what you're asking. You want the alias removed? Or you'd like the alias in another location? Are you up to speed on the discussion in #2156? |
LGTM |
Hmmm, we are still using the alias: $ git grep GrpcRendezvous
oogle/cloud/bigtable/row_data.py: :type response_iterator: :class:`~google.cloud.exceptions.GrpcRendezvous`
google/cloud/bigtable/table.py: :rtype: :class:`~google.cloud.exceptions.GrpcRendezvous`
google/cloud/datastore/connection.py:from google.cloud.exceptions import GrpcRendezvous
google/cloud/datastore/connection.py: except GrpcRendezvous as exc:
google/cloud/exceptions.py:GrpcRendezvous = _Rendezvous
system_tests/bigtable.py: from google.cloud.exceptions import GrpcRendezvous
system_tests/bigtable.py: retry = RetryErrors(GrpcRendezvous,
unit_tests/_testing.py: from google.cloud.exceptions import GrpcRendezvous
unit_tests/_testing.py: return GrpcRendezvous(exc_state, None, None, None)
unit_tests/datastore/test_connection.py: from google.cloud.exceptions import GrpcRendezvous
unit_tests/datastore/test_connection.py: exc = GrpcRendezvous(exc_state, None, None, None)
unit_tests/datastore/test_connection.py: from google.cloud.exceptions import GrpcRendezvous
unit_tests/datastore/test_connection.py: exc = GrpcRendezvous(exc_state, None, None, None)
unit_tests/datastore/test_connection.py: self._commit_failure_helper(exc, GrpcRendezvous) |
Thanks @tseaver I should have grepped that. Those would be candidates for this change as well right? |
datastore and bigtable don't use GAX. |
What @tseaver said. The alias is still "required" in the sense that we still need to catch a |
FYI @geigerj and @bjwatson