Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 2336 and upgrade to google-gax>=0.14.1 #2388

Merged
merged 3 commits into from
Sep 22, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 22, 2016

In the process, adding back code changes that were
reverted in the process of reverting PR googleapis#2336. Some of
the changes were necessary, but anything using GAX
(logging and pubsub) could safely be restored.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2016
@daspecster
Copy link
Contributor

Is GrcpRendezvous used somewhere else that would prevent the removal of that class from exceptions.py? (there are some pylint overrides around it's definition.)

@dhermes
Copy link
Contributor Author

dhermes commented Sep 22, 2016

@daspecster I'm not sure what you're asking. You want the alias removed? Or you'd like the alias in another location? Are you up to speed on the discussion in #2156?

@tseaver
Copy link
Contributor

tseaver commented Sep 22, 2016

LGTM

@dhermes dhermes merged commit 6b5223d into googleapis:master Sep 22, 2016
@dhermes dhermes deleted the revert-2336 branch September 22, 2016 18:36
@daspecster
Copy link
Contributor

@dhermes, yeah I was asking if the alias could be removed.

@tseaver
Copy link
Contributor

tseaver commented Sep 22, 2016

Hmmm, we are still using the alias:

$ git grep GrpcRendezvous
oogle/cloud/bigtable/row_data.py:    :type response_iterator: :class:`~google.cloud.exceptions.GrpcRendezvous`
google/cloud/bigtable/table.py:        :rtype: :class:`~google.cloud.exceptions.GrpcRendezvous`
google/cloud/datastore/connection.py:from google.cloud.exceptions import GrpcRendezvous
google/cloud/datastore/connection.py:        except GrpcRendezvous as exc:
google/cloud/exceptions.py:GrpcRendezvous = _Rendezvous
system_tests/bigtable.py:    from google.cloud.exceptions import GrpcRendezvous
system_tests/bigtable.py:        retry = RetryErrors(GrpcRendezvous,
unit_tests/_testing.py:        from google.cloud.exceptions import GrpcRendezvous
unit_tests/_testing.py:        return GrpcRendezvous(exc_state, None, None, None)
unit_tests/datastore/test_connection.py:        from google.cloud.exceptions import GrpcRendezvous
unit_tests/datastore/test_connection.py:        exc = GrpcRendezvous(exc_state, None, None, None)
unit_tests/datastore/test_connection.py:        from google.cloud.exceptions import GrpcRendezvous
unit_tests/datastore/test_connection.py:        exc = GrpcRendezvous(exc_state, None, None, None)
unit_tests/datastore/test_connection.py:        self._commit_failure_helper(exc, GrpcRendezvous)

@daspecster
Copy link
Contributor

Thanks @tseaver I should have grepped that.

Those would be candidates for this change as well right?

@tseaver
Copy link
Contributor

tseaver commented Sep 22, 2016

datastore and bigtable don't use GAX.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 22, 2016

What @tseaver said. The alias is still "required" in the sense that we still need to catch a _Rendezvous in the Bigtable and Datastore implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants