Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resource manager code into a subpackage #2435

Merged
merged 2 commits into from
Sep 26, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 26, 2016

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-resource_manager-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package resource-manager \
  --package-name "Google Cloud Resource Manager" \
  --readme "${READMES_DIR}/resource_manager/README.rst"

NOTE: A new commit was added to the script to handle the -/_ switch for multi-name packages.

@dhermes dhermes added packaging api: cloudresourcemanager Issues related to the Resource Manager API. labels Sep 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2016
@dhermes dhermes force-pushed the make-resource_manager-subpackage branch from 2579707 to 53e3443 Compare September 26, 2016 21:44
Done via:

$ mkdir -p resource_manager/google/cloud
$ cp google/__init__.py resource_manager/google/__init__.py
$ git add resource_manager/google/__init__.py
$ cp google/cloud/__init__.py resource_manager/google/cloud/__init__.py
$ git add resource_manager/google/cloud/__init__.py
$ git mv google/cloud/resource_manager resource_manager/google/cloud/resource_manager
$ git mv unit_tests/resource_manager resource_manager/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-resource-manager as a dependency to the umbrella
  package
- Adding the resource_manager subdirectory into the list of packages
  for verifying the docs
- Incorporating the resource_manager subdirectory into the umbrella
  coverage report
- Adding the resource-manager only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the resource-manager
  tox config
@dhermes dhermes force-pushed the make-resource_manager-subpackage branch from 53e3443 to 7cb86b4 Compare September 26, 2016 23:16
@dhermes dhermes merged commit 685341a into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-resource_manager-subpackage branch September 26, 2016 23:16
@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

Failed for similar reasons as #2436, but I fixed up and rebased before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudresourcemanager Issues related to the Resource Manager API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants