Fix #239: remove / document 'pragma: NO COVER'

[tseaver]

See #239 for discussion.

[coveralls]

Coverage decreased (-0.03%) when pulling 84e181e on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

[coveralls]

Coverage decreased (-0.03%) when pulling 6497cd3 on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

[coveralls]

Coverage remained the same when pulling 6497cd3 on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

[coveralls]

Coverage remained the same when pulling 4c7b14b on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

[tseaver]

The cleanup you are referring to in #238:

https://github.com/GoogleCloudPlatform/gcloud-python/pull/238/files#diff-131c11d8f72de47362212af2ee7c7791L871

Doesn't apply here, as the repeated definition is not present on master (or this branch). It could perhaps be factored out of 'gcloud.test_credentials' into something like 'gcloud._testing'.

[coveralls]

Coverage remained the same when pulling 4c7b14b on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

[tseaver]

I'm pretty displeased with the E124 and related errors pep8 is spitting out by default: there is no obviously-better way to spell assertions comparing data structures that doesn't fall afoul of one
or more of its rules. E.g., even after indenting one more space to the code in https://github.com/tseaver/gcloud-python/blob/63eb552e8d4a4616b60f8e55726cdbf9d098d3c3/gcloud/storage/test_connection.py#L587-L591, I sill ended up rewriting the assertions in 4c7b14b because I couldn't figure it out.

I'd just as soon turn of all their "hanging indent" checks.

[dhermes]

RE: E124 see #238 (comment)

The main thrust is that things like

        self.assertEqual(params,
                        {'Signature': [SIGNED],
                         'Expires': ['1000'],
                         'GoogleAccessId': [_Credentials.service_account_name],
                        })

are actually against PEP8 because by having

        self.assertEqual(params,

does not make it a continuation.

To make it valid, it would have to actually be a continuation

        self.assertEqual(
            params,
            {'Signature': [SIGNED],
             'Expires': ['1000'],
             'GoogleAccessId': [_Credentials.service_account_name],
            })

[dhermes]

RE: Cleanup, it's on master:
https://github.com/GoogleCloudPlatform/gcloud-python/blob/0e99f7b9cb444eda4b8d35e389d3a838fb2d8aad/gcloud/datastore/test_connection.py#L871
and has been since f6a4306.

[tseaver]

Have a look at the examples under: http://legacy.python.org/dev/peps/pep-0008/#indentation

They do not require that the opening paren of a function call be the last character when wrapping. E.g., this is in the "OK" block:

# Aligned with opening delimiter.
foo = long_function_name(var_one, var_two,
                         var_three, var_four)

as is this for data structures:

my_list = [
    1, 2, 3,
    4, 5, 6,
    ]

[tseaver]

The redundant '_Monkey' you point to is in 'gcloud.datastore.test_connection', which this PR doesn't touch: it does touch 'gcould.storage.test_connection', but reuses the '_Monkey' from 'gcloud.test_credentials'.

[coveralls]

Coverage remained the same when pulling a6bf98f on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

[tseaver]

See #250, which moves the '_Monkey' class into a new 'gcloud._testing' module (to avoid having one testcase module depend on another).

[tseaver]

@dhermes My "arguing with the ref" about pep8 E124 is actually irrelevant to this PR, because I rewrote the problematic statements to avoid it altogether. Are there remaining issues?

[dhermes]

Ah yes, good call.

This PR LGTM.