Fix #170: handle namespaces in queries #255

tseaver · 2014-10-17T15:25:54Z

Review this PR after #254 is merged (it is based from that branch).

Fixes #170.

coveralls · 2014-10-17T15:32:54Z

Coverage remained the same when pulling 3b582a7 on tseaver:170-query_namespaces into 906700b on GoogleCloudPlatform:master.

tseaver · 2014-10-17T20:15:10Z

Merged from the trunk: the earlier changesets (from PR #253) are now gone from the diff.

coveralls · 2014-10-17T20:21:28Z

Coverage remained the same when pulling 8a4ee61 on tseaver:170-query_namespaces into 83e8262 on GoogleCloudPlatform:master.

tseaver · 2014-10-17T21:54:13Z

Now rebased for your viewing pleasure.

coveralls · 2014-10-17T22:03:50Z

Coverage remained the same when pulling 7820d91 on tseaver:170-query_namespaces into 83e8262 on GoogleCloudPlatform:master.

gcloud/datastore/query.py

        clone._pb.CopyFrom(self._pb)
        clone._cursor = self._cursor
        return clone

+    def namespace(self):


dhermes · 2014-10-19T17:38:09Z

It seems namespace would occur in more places. Did you systematically go through methods with grep or something? In other words, do we have some way of knowing this is comprehensive?

tseaver · 2014-10-19T21:03:11Z

I looked at all the places that 'namespace' appeared in the protobuf spec, and verified that we were handling all of them:

'namespace' is a field in the PartitionId struct
That struct occurs only as a field of Key objects and a field of RunQueryRequest

We are handling those cases with this change.

Rather than those for testcase's '_makeOne'.

Fixes #170.

tseaver · 2014-10-19T21:08:07Z

I have rebased to fix the merge conflicts.

coveralls · 2014-10-19T21:16:55Z

Coverage remained the same when pulling bfffdbf on tseaver:170-query_namespaces into 86b308a on GoogleCloudPlatform:master.

dhermes · 2014-10-19T22:41:36Z

From viewing the discovery doc it seems the namespace can be included in the key as well.

Otherwise LGTM

tseaver · 2014-10-19T23:30:24Z

Right, but we already allow for passing the namespace to the Key ctor, setting / geting it through a 'namespace' method, and copying it to / from the PartitionId protobuf element. It was only the 'run_query' bits which lacked support until this PR.

Fix #170: handle namespaces in queries

chore: relocate owl bot post processor

* chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: add `available_cpu ` field feat: add `kms_key_name` field to ServiceConfig (the CMEK use case) feat: add `max_instance_request_concurrency` field feat: add `security_level` field PiperOrigin-RevId: 516979219 Source-Link: googleapis/googleapis@650f7cd Source-Link: googleapis/googleapis-gen@3c4d23f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2M0ZDIzZmQ3NjZlZGRiMmM3MjZiNDBkMjNlZjAxMjk3NGEzMjUxZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

@parthea

* docs: fix docstring formatting Committer: @parthea PiperOrigin-RevId: 410563372 Source-Link: googleapis/googleapis@23a388d Source-Link: googleapis/googleapis-gen@426ebb9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDI2ZWJiOTBlNjc3MzNiOWU1NTUwNmQyZDk4Mjk2MTdjMjg3Zjk5OCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790

* docs(samples): add checksum snippets Source-Link: googleapis/synthtool@571ee2c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:660abdf857d3ab9aabcd967c163c70e657fcc5653595c709263af5f3fa23ef67 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * lint * lint * lint * remove extra blank line * lint * Fix `google-crc32c` pin in samples/snippets/requirements.txt Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

* chore: release 2.1.0 * Update CHANGELOG.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Bu Sun Kim <[email protected]>

Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

chore: relocate owl bot post processor

…255) Source-Link: https://togithub.com/googleapis/synthtool/commit/b4fe62efb5114b6738ad4b13d6f654f2bf4b7cc0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: use gapic-generator-python 0.58.4 fix: provide appropriate mock values for message body fields committer: dovs PiperOrigin-RevId: 419025932 Source-Link: googleapis/googleapis@73da669 Source-Link: googleapis/googleapis-gen@46df624 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9 * chore: use gapic-generator-python 0.58.4 fix: provide appropriate mock values for message body fields committer: dovs PiperOrigin-RevId: 419025932 Source-Link: googleapis/googleapis@73da669 Source-Link: googleapis/googleapis-gen@46df624 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.11.7 PiperOrigin-RevId: 573230664 Source-Link: googleapis/googleapis@93beed3 Source-Link: googleapis/googleapis-gen@f4a4eda Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhNGVkYWE4MDU3NjM5ZmNmNmFkZjkxNzk4NzIyODBkMWE4ZjY1MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.8 PiperOrigin-RevId: 574178735 Source-Link: googleapis/googleapis@7307199 Source-Link: googleapis/googleapis-gen@ce3af21 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UzYWYyMWI3YzU1OWE4N2MyYmVmYzA3NmJlMGUzYWVkYTNhMjZmMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

These two lines bring the rules on this repo in line with the defaults: https://github.com/googleapis/repo-automation-bots/blob/63c858e539e1f4d9bb8ea66e12f9c0a0de5fef55/packages/sync-repo-settings/src/required-checks.json#L40-L50

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

* chore: allow releases on previous majors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Bu Sun Kim <[email protected]>

Co-authored-by: Anthonios Partheniou <[email protected]>

@busunkim96

- [ ] Regenerate this pull request now. fix: add 'dict' annotation type to 'request' Committer: @busunkim96 PiperOrigin-RevId: 398509016 Source-Link: googleapis/googleapis@b224dfa Source-Link: googleapis/googleapis-gen@63a1db7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjNhMWRiN2EzOGQ3NGI5NjM5NTkyZjUyMWVkMWRhYWY3Mjk5YWQ5YSJ9

Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update post processor image * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix typo * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Also, avoid using default environment credentials in unit tests

chore: relocate owl bot post processor

…[autoapprove] (#255) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

tseaver mentioned this pull request Oct 17, 2014

Add support for namespaces #1

Closed

dhermes reviewed Oct 19, 2014
View reviewed changes

gcloud/datastore/query.py

clone._pb.CopyFrom(self._pb)

clone._cursor = self._cursor

return clone

def namespace(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 4 commits October 19, 2014 17:03

Test *real* ctor defaults.

6a732f1

Rather than those for testcase's '_makeOne'.

Add namespace to query ctor / clone.

b7bee41

Typos.

c120f65

Pass namespace when fetching results.

bfffdbf

Fixes #170.

tseaver added a commit that referenced this pull request Oct 19, 2014

Merge pull request #255 from tseaver/170-query_namespaces

67b8302

Fix #170: handle namespaces in queries

tseaver merged commit 67b8302 into googleapis:master Oct 19, 2014

tseaver deleted the 170-query_namespaces branch October 19, 2014 23:31

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore: relocate owl bot post processor (#255)

b0ad55d

chore: relocate owl bot post processor

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: relocate owl bot post processor (#255)

2cc0a82

chore: relocate owl bot post processor

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: relocate owl bot post processor (#255)

194b45b

chore: relocate owl bot post processor

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore: relocate owl bot post processor (#255)

e61007d

chore: relocate owl bot post processor

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-api-core to v2.10.2 (#255)

5c0e0d1

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.11.0 (#255)

900ad73

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore: make samples 3.6 check optional (#255)

7a5c017

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore: release 2.1.0 (#255)

463333e

* chore: release 2.1.0 * Update CHANGELOG.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Bu Sun Kim <[email protected]>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: relocate owl bot post processor (#255)

cdc9adc

chore: relocate owl bot post processor

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.10.0 (#255)

6f73848

parthea added a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-monitoring to v2.8.0 (#255)

a7f242d

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pillow to v8.4.0 (#255)

c887148

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: drop six (#255)

339af1d

Also, avoid using default environment credentials in unit tests

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: allow releases from previous major versions (#255)

659e91e

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore: relocate owl bot post processor (#255)

8363384

chore: relocate owl bot post processor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #170: handle namespaces in queries #255

Fix #170: handle namespaces in queries #255

tseaver commented Oct 17, 2014

coveralls commented Oct 17, 2014

tseaver commented Oct 17, 2014

coveralls commented Oct 17, 2014

tseaver commented Oct 17, 2014

coveralls commented Oct 17, 2014

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014

tseaver commented Oct 19, 2014

coveralls commented Oct 19, 2014

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014

Fix #170: handle namespaces in queries #255

Fix #170: handle namespaces in queries #255

Conversation

tseaver commented Oct 17, 2014

coveralls commented Oct 17, 2014

tseaver commented Oct 17, 2014

coveralls commented Oct 17, 2014

tseaver commented Oct 17, 2014

coveralls commented Oct 17, 2014

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014

tseaver commented Oct 19, 2014

coveralls commented Oct 19, 2014

dhermes commented Oct 19, 2014

tseaver commented Oct 19, 2014