Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #168 and #169: Rationalize 'Connection.delete_entities' #257

Merged
merged 2 commits into from
Oct 19, 2014
Merged

Fix #168 and #169: Rationalize 'Connection.delete_entities' #257

merged 2 commits into from
Oct 19, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 17, 2014

Please review this after PR #253 (it is based on that branch).

Fixes #168 and #169.

Supersedes PR #256.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8ebace3 on tseaver:168_169-connection_delete_entities into 906700b on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2014

Merged from the trunk: the earlier changesets (from PR #253) are now gone from the diff.

@dhermes
Copy link
Contributor

dhermes commented Oct 17, 2014

Can you rebase instead of merging so as not to introduce unnecessary commits into our history?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 63b08a5 on tseaver:168_169-connection_delete_entities into 83e8262 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2014

Rebasing an already-shared branch is not part of my normal workflow. After reading up here and here, I've tried the rebase as:

$ git checkout 168_169-connection_delete_entities
$ git rebase master
$ git push -f   # douche chill

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7e134d3 on tseaver:168_169-connection_delete_entities into 83e8262 on GoogleCloudPlatform:master.

@@ -403,8 +403,7 @@ def delete_entities(self, dataset_id, key_pbs):

:rtype: boolean (if in a transaction) or else
:class:`gcloud.datastore.datastore_v1_pb2.MutationResult`.
:returns: True (if in a transaction) or else a mutation result
protobuf.
:returns: True

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Oct 19, 2014

Overall LGTM.

It seems strange to have delete_entities defined on Connection. That strangeness isn't dealt with here, but is worth discussing / potentially filing a follow up bug to refactor.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 19, 2014

Rebased to resolve merge conflicts.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 19, 2014

WRT "strangeness": note that the connection mediates all mutations passed to the backend (saves, deletes, commits). Loading / storing / deleting entities is basically its only responsibility.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e8dda0f on tseaver:168_169-connection_delete_entities into 20ac9ef on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Oct 19, 2014
Fix #168 and #169:  Rationalize 'Connection.delete_entities'
@tseaver tseaver merged commit 714cd5d into googleapis:master Oct 19, 2014
@tseaver tseaver deleted the 168_169-connection_delete_entities branch October 19, 2014 21:40
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
atulep pushed a commit that referenced this pull request Apr 3, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [2.9.1](https://www.github.com/googleapis/python-speech/compare/v2.9.0...v2.9.1) (2021-09-24)


### Bug Fixes

* add 'dict' annotation type to 'request' ([e75ada8](https://www.github.com/googleapis/python-speech/commit/e75ada858d00b22fbae6d0de40771239d2f71756))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
atulep pushed a commit that referenced this pull request Apr 6, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [2.9.1](https://www.github.com/googleapis/python-speech/compare/v2.9.0...v2.9.1) (2021-09-24)


### Bug Fixes

* add 'dict' annotation type to 'request' ([e75ada8](https://www.github.com/googleapis/python-speech/commit/e75ada858d00b22fbae6d0de40771239d2f71756))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
atulep pushed a commit that referenced this pull request Apr 6, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [2.9.1](https://www.github.com/googleapis/python-speech/compare/v2.9.0...v2.9.1) (2021-09-24)


### Bug Fixes

* add 'dict' annotation type to 'request' ([e75ada8](https://www.github.com/googleapis/python-speech/commit/e75ada858d00b22fbae6d0de40771239d2f71756))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
atulep pushed a commit that referenced this pull request Apr 18, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [2.9.1](https://www.github.com/googleapis/python-speech/compare/v2.9.0...v2.9.1) (2021-09-24)


### Bug Fixes

* add 'dict' annotation type to 'request' ([e75ada8](https://www.github.com/googleapis/python-speech/commit/e75ada858d00b22fbae6d0de40771239d2f71756))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
parthea pushed a commit that referenced this pull request Jun 4, 2023
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
parthea pushed a commit that referenced this pull request Jun 4, 2023
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this pull request Jun 4, 2023
🤖 I have created a release \*beep\* \*boop\*
---
## [3.6.0](https://www.github.com/googleapis/python-datacatalog/compare/v3.5.0...v3.6.0) (2021-11-08)


### Features

* Added BigQueryDateShardedSpec.latest_shard_resource field ([#256](https://www.github.com/googleapis/python-datacatalog/issues/256)) ([36019b6](https://www.github.com/googleapis/python-datacatalog/commit/36019b6218ed8153ef9cdcfc2d57434c6e7f0b25))
* Added SearchCatalogResult.description field ([36019b6](https://www.github.com/googleapis/python-datacatalog/commit/36019b6218ed8153ef9cdcfc2d57434c6e7f0b25))
* Added SearchCatalogResult.display_name field ([36019b6](https://www.github.com/googleapis/python-datacatalog/commit/36019b6218ed8153ef9cdcfc2d57434c6e7f0b25))


### Bug Fixes

* **deps:** drop packaging dependency ([0dcc0c3](https://www.github.com/googleapis/python-datacatalog/commit/0dcc0c36484ac8013ba911322d7641f5b73efe11))
* **deps:** require google-api-core >= 1.28.0 ([0dcc0c3](https://www.github.com/googleapis/python-datacatalog/commit/0dcc0c36484ac8013ba911322d7641f5b73efe11))


### Documentation

* attempt to fix table layout ([#249](https://www.github.com/googleapis/python-datacatalog/issues/249)) ([26c19ae](https://www.github.com/googleapis/python-datacatalog/commit/26c19ae8bbe96f7a82e4f36a251e7abea98ce2b1))
* list oneofs in docstring ([0dcc0c3](https://www.github.com/googleapis/python-datacatalog/commit/0dcc0c36484ac8013ba911322d7641f5b73efe11))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea added a commit that referenced this pull request Jun 4, 2023
parthea added a commit that referenced this pull request Jun 4, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
* feat: [Cloud Memorystore for Redis] Add CMEK key field
feat: [Cloud Memorystore for Redis] Add suspension_reasons field
feat: [Cloud Memorystore for Redis] Add persistence support
feat: [Cloud Memorystore for Redis] Add self service update maintenance version support

PiperOrigin-RevId: 529822563

Source-Link: googleapis/googleapis@6a0ac6d

Source-Link: googleapis/googleapis-gen@66da9c3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjZkYTljMzIyZGViNzVmYjg5ZDVhMzUwNWY1NzI2NDRkNGYwNzY5OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@ca87909
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 14, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: googleapis/googleapis-gen@4313d68
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [3.2.3](https://www.github.com/googleapis/python-dlp/compare/v3.2.2...v3.2.3) (2021-09-24)


### Bug Fixes

* add 'dict' annotation type to 'request' ([ff98215](https://www.github.com/googleapis/python-dlp/commit/ff98215e7dc3fc6a2e8b04e3b8e570cd72556f4f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@d52e638
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@6252f2c
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:50e35228649c47b6ca82aa0be3ff9eb2afce51c82b66c4a03fe4afeb5ff6c0fc
parthea added a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
…257)

Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Oct 22, 2023
Source-Link: googleapis/synthtool@0ddbff8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
…ic enums (#257)

* feat: enable "rest" transport in Python for services supporting numeric enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [2.9.1](https://www.github.com/googleapis/python-speech/compare/v2.9.0...v2.9.1) (2021-09-24)


### Bug Fixes

* add 'dict' annotation type to 'request' ([e75ada8](https://www.github.com/googleapis/python-speech/commit/e75ada858d00b22fbae6d0de40771239d2f71756))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 22, 2023
Source-Link: googleapis/synthtool@69fabae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387
parthea pushed a commit that referenced this pull request Oct 31, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In datastore.connection.Connection.delete_entities, make return values consistent with one another
3 participants