Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make make_secure_channel use google-auth #2808

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Make make_secure_channel use google-auth #2808

merged 2 commits into from
Dec 5, 2016

Conversation

theacodes
Copy link
Contributor

Resolves #2797

@theacodes theacodes added the auth label Dec 5, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
@theacodes
Copy link
Contributor Author

@dhermes note that this adds grpc as a test dep for core.

dhermes
dhermes approved these changes Dec 5, 2016
View reviewed changes
core/tox.ini
@@ -6,6 +6,7 @@ envlist =
deps =
mock
pytest
grpcio

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes merged commit d20f3bb into googleapis:master Dec 5, 2016
@theacodes theacodes deleted the make-secure-chanel branch December 5, 2016 20:56
@dhermes dhermes mentioned this pull request Dec 5, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Make make_secure_channel use google-auth (googleapis#2808)
37fd8f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
auth cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theacodes @dhermes @googlebot