Making datastore Connection.run_query() return low-level protobuf. #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards googleapis#2746 (as is googleapis#3064). This approach is to slowly transition from our current approach to use the GAPIC generated surface. These unit tests weren't so bad to update. I did "editorialize" as I went, downgrading constants to just variables, renamining for PEP8, etc.
googlebot
added
the
cla: yes
|
@dhermes Is your goal to get this into the umbrella release, or put it off until after? (I am okay with either as long as it does not block it.) |
daspecster
reviewed
Feb 24, 2017
|
|
||
| if cursor_as_bytes == b'': # Empty-value for bytes. | ||
| if response_pb.batch.end_cursor == b'': # Empty-value for bytes. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Feb 24, 2017
|
Approved, but holding off on merge until the umbrella release question is answered. |
|
@lukesneeringer This isn't release blocking. Only the guts have changed, so no user-facing implications. |
This was referenced Feb 24, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Making datastore Connection.run_query() return low-level protobuf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2746 (as is #3064). This approach is to slowly transition from our current approach to use the GAPIC generated surface.
These unit tests weren't so bad to update. I did "editorialize" as I went, downgrading constants to just variables, renamining for PEP8, etc.