Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing along client instead of project when creating error API. #3075

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Passing along client instead of project when creating error API. #3075

merged 1 commit into from
Feb 27, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 26, 2017 •
edited
Loading

Also changed a lot of the unit tests. Fixes #3071.

Between #3063 and this, my confidence in the error_reporting package is pretty shaken.

/cc @jonparrott @waprin

@dhermes dhermes added api: clouderrorreporting Issues related to the Error Reporting API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 26, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2017
@daspecster
Copy link
Contributor

This LGTM.

@dhermes dhermes merged commit aadb6a2 into googleapis:master Feb 27, 2017
@lukesneeringer
Copy link
Contributor

@dhermes Mind if I make a minor release for this bugfix (for error reporting only)?
I would like to get in the habit of not "storing up" a bunch of stuff where possible, and this would be pretty easy to tag and send out.

@dhermes dhermes deleted the fix-3071 branch March 1, 2017 23:35
@dhermes
Copy link
Contributor Author

dhermes commented Mar 1, 2017

Not at all

@daspecster daspecster mentioned this pull request Mar 8, 2017
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#3075 from dhermes/fix-3071
00c3011 
Passing along client instead of project when creating error API.
parthea pushed a commit that referenced this pull request Jul 6, 2023
@jsimonweb @busunkim96
Remove unused region_tag comment. [(#3075)](GoogleCloudPlatform/pytho…
dde0198 
…n-docs-samples#3075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels
api: clouderrorreporting Issues related to the Error Reporting API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @daspecster @lukesneeringer @tseaver @googlebot