Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring datastore Gax exception re-mapping. #3163

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Restoring datastore Gax exception re-mapping. #3163

merged 1 commit into from
Mar 17, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 17, 2017

Fixes #2746.

See previous source for reference.

@lukesneeringer I don't really like doing this, but I'm not sure if there's a better way to remap the GaxError-s to our google.cloud exceptions.

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Mar 17, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2017
@lukesneeringer
Copy link
Contributor

@lukesneeringer I don't really like doing this, but I'm not sure if there's a better way to remap the GaxError-s to our google.cloud exceptions.

It is fine for now. I would personally prefer rethink GaxError more generally, but that is a bigger project.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 17, 2017

👍 Worth filing an issue to track this? DERP on not running lint locally

daspecster
daspecster reviewed Mar 17, 2017
View reviewed changes
datastore/unit_tests/test__gax.py
with patch1 as mock_constructor:
ds_api = self._make_one()
mock_constructor.assert_called_once_with()
with patch2 as mock_lookup:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Mar 17, 2017 •
edited
Loading

👍 Worth filing an issue to track this?

Nah.

DERP on not running lint locally

My changes in #3146 should make that much easier in the workflow, since lint is moved into the individual packages.

@dhermes dhermes merged commit 45c6a0a into googleapis:master Mar 17, 2017
@dhermes dhermes deleted the wrap-up-2746 branch March 17, 2017 19:00
@dhermes
Copy link
Contributor Author

dhermes commented Mar 17, 2017

@lukesneeringer Naw it was just a DERP by me. tox -e lint is plenty fast when you set GOOGLE_CLOUD_TESTING_BRANCH and GOOGLE_CLOUD_TESTING_REMOTE (this PR only changed 2 files so it was very quick)

@lukesneeringer
Copy link
Contributor

Sure, but because I work inside packages, I often forget to cd .. and run lint and system tests separately.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#3163 from dhermes/wrap-up-2746
b1bece3 
Restoring datastore Gax exception re-mapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daspecster daspecster daspecster left review comments

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @lukesneeringer @daspecster @tseaver @googlebot