Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #151/#163: use ACL-specific endpoints where feasible for buckets and keys #318

Merged
merged 14 commits into from
Nov 1, 2014
Merged

Fix #151/#163: use ACL-specific endpoints where feasible for buckets and keys #318

merged 14 commits into from
Nov 1, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 31, 2014

  • Refactor lazy-handling of 'acl' and 'default_object_acl' using properties.
  • Fetch 'acl' and 'defaultObjectAcl' via GET to ACL-specific endpoints.
  • Continue to update 'acl' and 'defaultObjectAcl' via PATCH to the object's
    resource (we can't do incremental updates to ACEs).

Fixes #151 and #163.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e69c8fc on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. labels Oct 31, 2014
@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2014

The demo still runs with this branch, but it doesn't exercise the ACL stuff, which is borked. Review is OK, but I need to track that breakage down.

@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 31, 2014
@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2014

As of e74972d, I can now save / clear ACLs for buckets and keys.

ccf2a96 adds support for the fact that the back-end makes some bucket ACL entries "sticky" (they are preserved fter a successful PATCH with
data == {'acl': []}.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ccf2a96 on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c5c9246 on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

dhermes
dhermes reviewed Oct 31, 2014
View reviewed changes
gcloud/storage/bucket.py
:rtype: :class:`Bucket`
:returns: The bucket you just reloaded data for.
"""
projection = 'full' if full else 'noAcl'

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 89c80fa on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

dhermes
dhermes reviewed Oct 31, 2014
View reviewed changes
gcloud/storage/bucket.py
query_params={'projection': 'full'})
self.acl.clear()
for entry in result['acl']:
self.acl.entity(self.acl.entity_from_dict(entry))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4dde9cb on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4dde9cb on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a4bb709 on tseaver:151-163-use_acl_endpoints into * on GoogleCloudPlatform:master*.

This was referenced Oct 31, 2014
Closed
Closed
Merged
dhermes
dhermes reviewed Oct 31, 2014
View reviewed changes
gcloud/storage/bucket.py
@@ -341,9 +351,13 @@ def get_metadata(self, field=None, default=None):
:rtype: dict or anything
:returns: All metadata or the value of the specific field.
"""
# We ignore 'acl' / 'defaultObjectAcl' because they should be
# handled via 'get_acl()' / 'get_default_object_acl()'
if field in ('acl', 'defaultObjectAcl'):

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Oct 31, 2014

LGTM, though if you want to raise a KeyError for uses of metadata methods for ACL stuff I'm cool with that. We could also file an issue and follow up after this PR.

@tseaver
Allow clearing an ACL.
7f4fe7c
@tseaver
Add a 'loaded' flag to ACLs.
2d89c38 
'reset()' clears it, along with entities.

'add_entity()' sets it.
@tseaver
Neaten.
b524729
@tseaver
Use ACL-specific endpoints where feasible for buckets.
6fe5372 
- Refactor lazy-handling of 'acl' and 'default_object_acl' using properties.

- Fetch 'ac' and 'defaultObjectAcl' via GET to specific endpoints.

- Continue to update 'acl' and 'defaultObjectAcl' via PATCH to the object's
  resource (we can't do incremental updates to ACEs).

Fixes #163.
@tseaver
Use ACL-specific endpoints where feasible for keys.
de2ad66 
- Refactor lazy-handling of 'acl' using a property.

- Fetch 'acl' via GET to a specific endpoint.

- Continue to update 'acl' via PATCH to the object's resource (we can't do
  incremental updates to ACEs).

Fixes #151.
@tseaver
Fix save/clear ACL operations.
b7d2feb 
Borked by dropping the 'projection' qs param to PATCH.  Docs spell
a default, but then note that overriding it w/ 'full' is required
(and we need 'full' anyway, because we expect to read the resulting
ACL back).
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
fix: resolve DuplicateCredentialArgs error when using credentials_file (
8d7f73d 
#318)


committer: parthea
PiperOrigin-RevId: 425964861

Source-Link: googleapis/googleapis@84b1a5a

Source-Link: googleapis/googleapis-gen@4fb761b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
fix: resolve DuplicateCredentialArgs error when using credentials_file (
683c06e 
#318)


committer: parthea
PiperOrigin-RevId: 425964861

Source-Link: googleapis/googleapis@84b1a5a

Source-Link: googleapis/googleapis-gen@4fb761b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 1.4.1 (#318)
3a59d6b 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @parthea
chore(deps): update dependency google-auth to v2.15.0 (#318)
a84fb96 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
build(deps): bump cryptography to 41.0.0 [autoapprove] (#318)
a2c9f48 
Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 2.9.1 (#318)
ff5aab7 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.12.0 (#318)
7c884ac
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 2.12.0 (#318)
89c90da 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@renovate-bot
chore(deps): update dependency google-api-python-client to v2.48.0 (#318
227f165 
)
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
feat: added support for segment template manifest generation with DASH (
6ea2d38 
#318)

* feat: added support for segment template manifest generation with DASH
feat: added support for batch mode priority
feat: added support for disabling job processing optimizations
feat: added support for content encryption (DRM)

PiperOrigin-RevId: 546916731

Source-Link: googleapis/googleapis@f1f8ba4

Source-Link: googleapis/googleapis-gen@6ddcc2d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmRkY2MyZGQ4MmJiYTkzY2JkZmUzOTdlZWVmMTYyZTVhNDAzZDU4ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Sep 20, 2023
Closed
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore: add kokoro 3.9 config templates (#318)
aa3dbfa 
Source-Link: googleapis/synthtool@b0eb8a8
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:df50e8d462f86d6bcb42f27ecad55bb12c404f1c65de9c6fe4c4d25120080bd6
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: store artifacts in placer [autoapprove] (#318)
463b675 
Source-Link: https://togithub.com/googleapis/synthtool/commit/cb960373d12d20f8dc38beee2bf884d49627165e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt [autoa…
bac7228 
…pprove] (#318)

Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
feat: add a FastSocket API (#318)
fb32a80 
* feat: add a FastSocket API

PiperOrigin-RevId: 491259489

Source-Link: googleapis/googleapis@39bcdf4

Source-Link: googleapis/googleapis-gen@ee2470d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWUyNDcwZDllNzkwNmQwNzY0YWRiNTYyZjRkNGNjNDFmMGQ2Yzk2ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
feat: add Spark runtime versioning for Spark batches (#318)
9adacec 
- [ ] Regenerate this pull request now.

Committer: @medb
PiperOrigin-RevId: 420175701

Source-Link: googleapis/googleapis@1116092

Source-Link: googleapis/googleapis-gen@72c0b7f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJjMGI3ZjRkY2RmMmNkNGQ0NzI5NzY5Y2JkZWIyYjIyOGM1MDRlMSJ9

feat: custom image containers for Spark batches 
feat: auto-diagnostic of failed Spark batches 
feat: local SSD NVME interface support for GCE clusters
parthea added a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot @parthea
ci(python): run lint / unit tests / docs as GH actions (#318)
5d4455f 
* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): drop flake8-import-order in samples noxfile (#318)
b1527f8 
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot @parthea
feat: field ObjectTrackingAnnotation.segment moved into oneof, added …
5d713de 
…track_id (#318)

* chore: use gapic-generator-python 0.65.2

PiperOrigin-RevId: 444333013

Source-Link: googleapis/googleapis@f91b6cf

Source-Link: googleapis/googleapis-gen@16eb360
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat!: field ObjectTrackingAnnotation.segment moved into oneof, added track_id

PiperOrigin-RevId: 445061085

Source-Link: googleapis/googleapis@0506e19

Source-Link: googleapis/googleapis-gen@5796d51
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTc5NmQ1MTU1ZGY5YTM3OGMwZmQ4ZDk3YzA2ZjdkNzE3MDc2NTY3MCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): modify templated noxfile to support non-cloud APIs (#318)
e7fa924 
Source-Link: googleapis/synthtool@76d5fec
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:979d9498e07c50097c1aeda937dcd32094ecc7440278a83e832b6a05602f62b6

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): exclude grpcio==1.49.0rc1 in tests [autoapprove] (#318)
bd90030 
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: resolve issue with prerelease presubmit [autoapprove] (#318)
790ea69 
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update dependency pyupgrade to v2.32.1 (#318)
1447f4e 
Source-Link: googleapis/synthtool@35e1ea8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:73564f768388926a050a7a957650bfd1f584df6e0b3512e199a8e12d9dfc4618

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2 (#318)
348120b
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 0.14.1 (#318)
ccd7be0 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): update release script dependencies [autoapprove] (#318)
e2e86e7 
Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
feat: publish updated protos for cloud/automl/v1 service (#318)
2c95387 
* fix: proto field markdown comment for the display_name field in annotation_payload.proto to point the correct public v1/ version fix: Add back java_multiple_files option to the text_sentiment.proto to match with the previous published version of text_sentiment proto

PiperOrigin-RevId: 421849336

Source-Link: googleapis/googleapis@5c24921

Source-Link: googleapis/googleapis-gen@0195e8e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDE5NWU4ZTQ1ZjQxMjI1ZGRlMTViM2EyNGZlODllZDI3Njg2Y2I2NCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/setup-python action to v4 [autoapprove] (#…
25fee0f 
…318)

Source-Link: googleapis/synthtool@8e55b32
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c6c965a4bf40c19011b11f87dbc801a66d3a23fbc6704102be064ef31c51f1c3
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
fix: resolve DuplicateCredentialArgs error when using credentials_file (
7d6786c 
#318)


committer: parthea
PiperOrigin-RevId: 425964861

Source-Link: googleapis/googleapis@84b1a5a

Source-Link: googleapis/googleapis-gen@4fb761b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
fix: Add async context manager return types (#318)
ac40f41 
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In storage.Key.get_acl, account for very long list of ACLs
3 participants
@tseaver @coveralls @dhermes