Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #160: document how 'NotFoundError' propagates. #328

Merged
merged 3 commits into from
Nov 3, 2014
Merged

Fix #160: document how 'NotFoundError' propagates. #328

merged 3 commits into from
Nov 3, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 3, 2014

Describe suppressing it via 'bucket.delete_keys([key], on_error=lambda k:None'.

Fixes #160.

@tseaver
Document how 'NotFoundError' propagates.
16b581c 
Describe suppressing it via 'bucket.delete_keys([key], on_error=lambda k:None'.

Fixes #160.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 16b581c on tseaver:160-doc_avoid_notfound_when_del_key into f33e557 on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Nov 3, 2014
View reviewed changes
gcloud/storage/bucket.py
the exception, call ``delete_keys``, passing a no-op
``on_error`` callback, e.g.::

>>> bucket.delete_keys([key], on_error=lambda *key: pass)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7441438 on tseaver:160-doc_avoid_notfound_when_del_key into f33e557 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7441438 on tseaver:160-doc_avoid_notfound_when_del_key into f33e557 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Nov 3, 2014

LGTM

tseaver added a commit that referenced this pull request Nov 3, 2014
@tseaver
Merge pull request #328 from tseaver/160-doc_avoid_notfound_when_del_key
2b73c7b 
Fix #160:  document how 'NotFoundError' propagates.
@tseaver tseaver merged commit 2b73c7b into googleapis:master Nov 3, 2014
@tseaver tseaver deleted the 160-doc_avoid_notfound_when_del_key branch November 3, 2014 22:25
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Dec 31, 2015
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Fix bug in body setter as suggested in googleapis#328
302c4a0
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-recaptcha-enterprise to v…
98c7649 
…1.10.0 (#328)
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v3 (#328)
f772cc7
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 1.6.0 (#328)
bf97685 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-talent to v2.10.0 (#328)
81e357e
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.65.2 (#328)
118fe85 
* chore: use gapic-generator-python 0.65.2

PiperOrigin-RevId: 444333013

Source-Link: googleapis/googleapis@f91b6cf

Source-Link: googleapis/googleapis-gen@16eb360
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@kapishps @parthea @gcf-owl-bot
docs(samples): Added sample for creating Secret with UserManaged repl…
ce67682 
…ication (#328)

* added snippet and test

* updated copyright

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* pr comment changes

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jul 6, 2023
@parthea
chore: test minimum dependencies in python 3.7 (#328)
a508f1f
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore(python): update .kokoro/requirements.txt (#328)
51688ec 
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#328)
e23050d 
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore: release 2.6.0 (#328)
4471f94 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/python-dialogflow/compare/v2.5.0...v2.6.0) (2021-07-10)


### Features

* add always_use_jwt_access ([#320](https://www.github.com/googleapis/python-dialogflow/issues/320)) ([9bf371d](https://www.github.com/googleapis/python-dialogflow/commit/9bf371d38a4c55bbb349cc59c7fd7e9d49847560))


### Bug Fixes

* disable always_use_jwt_access ([9bf371d](https://www.github.com/googleapis/python-dialogflow/commit/9bf371d38a4c55bbb349cc59c7fd7e9d49847560))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.11.4 (#328)
e451b90 
* chore: Update gapic-generator-python to v1.11.4

PiperOrigin-RevId: 547897126

Source-Link: googleapis/googleapis@c09c75e

Source-Link: googleapis/googleapis-gen@45e0ec4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#328)
35b0f31 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 1.9.0 (#328)
8cd7747 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-container to v2.15.0 (#328)
dd5b3ca
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#328)
cce976e
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
docs: Fix formatting of request arg in docstring (#328)
e6eb81e 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
docs: Add documentation for enums (#328)
e407280 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update dependency pytest to v7.1.3 (#328)
a050754 
* chore(deps): update all dependencies

* revert

Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.7.1 (#328)
63add36 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-resource-manager to v1.3.1 (
2d45cdf 
#328)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): exclude path in renovate.json [autoapprove] (#328)
487ab86 
Source-Link: googleapis/synthtool@4826337
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:60a63eddf86c87395b4bb394fdddfe30f84a7726ee8fe0b758ea132c2106ac75
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: detect samples tests in nested directories (#328)
6f7e054 
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
chore: make samples 3.6 check optional (#328)
bbb5563
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.1 (#328)
6cf2c13
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore: Update gapic-generator-python to v1.8.5 (#328)
81a03d5 
* chore: Update gapic-generator-python to v1.8.5

PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 0.16.0 (#328)
2a02dc3 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 2.7.0 (#328)
2be3c33 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: [autoapprove] Pin flake8 version (#328)
fc65405 
Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider allowing storage.bucket.Bucket.delete_key to silently fail if user requests it
3 participants
@tseaver @coveralls @dhermes