Factoring out some Blob helpers. #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This is prep work for swapping out the upload implementation to use `google-resumable-media`.
dhermes
force-pushed
the
factor-out-some-blob-helpers
branch
from
74f8152
to
ec38e51
Compare
theacodes
approved these changes
May 2, 2017
| @@ -324,6 +325,23 @@ def delete(self, client=None): | |||
| """ | |||
| return self.bucket.delete_blob(self.name, client=client) | |||
|
|
|||
| def _make_transport(self, client): | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| _DOWNLOAD_URL_TEMPLATE = ( | ||
| u'https://www.googleapis.com/download/storage/v1{path}?alt=media') | ||
| _CONTENT_TYPE = 'contentType' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
This is prep work for swapping out the upload implementation to use `google-resumable-media`.
This was referenced Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prep work for swapping out the upload implementation to use
google-resumable-media.I just wanted to get "unrelated" and non-controversial changes out of the way before a big PR.