Vision semi-GAPIC #3373

lukesneeringer · 2017-05-04T20:51:15Z

This commit removes the entire Vision manual layer and replaces it with a thin wrapper around the GAPIC.

It makes several other changes:

The GAPIC and Protos are packaged alongside the library, rather than being separate packages on PyPI. (I plan to move toward this generally, but not all at once.)
The docs are updated.
The system tests are dramatically thinned down; more should be ported from the old tests before this goes anywhere.

Tagging this "do not merge" for now while other questions about this are worked out.

vision/.coveragerc

@@ -2,7 +2,7 @@
 branch = True

 [report]
-fail_under = 100
+# fail_under = 100


vision/MANIFEST.in

@@ -1,4 +1,4 @@
-include README.rst LICENSE
+include README.rst LICENSE requirements.txt


vision/google/cloud/gapic/__init__.py

@@ -0,0 +1 @@
+__import__('pkg_resources').declare_namespace(__name__)


vision/google/cloud/gapic/vision/v1/image_annotator_client.py

+    _ALL_SCOPES = ('https://www.googleapis.com/auth/cloud-platform', )
+
+    def __init__(self,
+                 service_path=SERVICE_ADDRESS,


vision/google/cloud/vision/__init__.py

@@ -1,4 +1,4 @@
-# Copyright 2016 Google Inc.
+# Copyright 2017, Google Inc. All rights reserved.


vision/google/cloud/vision_v1.py

+
+from __future__ import absolute_import
+
+from google.cloud.gapic.vision.v1 import image_annotator_client as iac


vision/google/cloud/vision_v1.py

+from google.cloud.gapic.vision.v1 import enums
+
+from google.cloud.proto.vision.v1 import geometry_pb2 as geometry
+from google.cloud.proto.vision.v1 import image_annotator_pb2 as image_annotator


vision/google/cloud/vision_v1.py

+@add_single_feature_methods
+class ImageAnnotatorClient(VisionHelpers, iac.ImageAnnotatorClient):
+    __doc__ = iac.ImageAnnotatorClient.__doc__
+    enums = enums


vision/setup.py

-    'zip_safe': False,
-    'classifiers': [
+cur_dir = os.path.realpath(os.path.dirname(__file__))
+with io.open('%s/requirements.txt' % cur_dir) as requirements_file:


vision/MANIFEST.in

@@ -1,4 +1,4 @@
-include README.rst LICENSE
+include README.rst LICENSE requirements.txt
 recursive-include google *.json *.proto


lukesneeringer and others added 10 commits May 3, 2017 08:13

[WIP] Vision semi-GAPIC

a558ef1

[WIP] Vision semi-GAPIC, with future proof single feature methods.

bbc0bc8

WIP

6f627e4

WIP

2f69e39

WIP

16daf25

[WIP] More Vision work.

7d975cb

Working Vision client.

04811d0

Re-adding old system tests; about to port.

92cea0f

Adding basic system tests.

f926516

Rewrote usage docs for Vision

cab525d

lukesneeringer added api: vision Issues related to the Cloud Vision API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 4, 2017

lukesneeringer self-assigned this May 4, 2017

lukesneeringer requested a review from theacodes May 4, 2017 20:51

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2017

theacodes reviewed May 4, 2017

View reviewed changes

Luke Sneeringer added 2 commits May 9, 2017 13:39

Re-add old manual layer.

29ae515

Deprecate the old manual layer.

7249a15

lukesneeringer force-pushed the vision-semi-gapic branch from f18fd9e to 7249a15 Compare May 9, 2017 20:47

Luke Sneeringer and others added 6 commits May 9, 2017 13:49

Remove requirements.txt

026a3c2

Re-add fail-under: 100 in .coveragerc

047d8d5

Fix credentials in unit test.

d01b94a

Only run system tests where credentials are set.

05063c3

File object support.

6e0f282

Vision unit tests for file handling.

18dce1c

tseaver reviewed May 17, 2017

View reviewed changes

vision/MANIFEST.in Outdated

@@ -1,4 +1,4 @@

include README.rst LICENSE

include README.rst LICENSE requirements.txt

recursive-include google *.json *.proto

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer and others added 4 commits May 23, 2017 07:17

Merge branch 'master' into vision-semi-gapic

27593d7

Fix Vision MANIFEST.in

42c2b2e

Update versions in metapackage.

d4cdde4

Modify a docstring. See if it makes sphinx not warn.

5566806

tseaver mentioned this pull request Jun 7, 2017

Move '_catch_remap_gax_error' to 'core.exceptions'. #3444

Closed

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 26, 2017

dhermes mentioned this pull request Jul 26, 2017

Cut release of vision API. #3677

Merged

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017

Vision semi-GAPIC (googleapis#3373)

62db662

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017

Vision semi-GAPIC (googleapis#3373)

31f8326

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017

Vision semi-GAPIC (googleapis#3373)

c8f8b9c

atulep pushed a commit that referenced this pull request Apr 3, 2023

Vision semi-GAPIC (#3373)

acd34f6

atulep pushed a commit that referenced this pull request Apr 18, 2023

Vision semi-GAPIC (#3373)

87aa90e

parthea pushed a commit that referenced this pull request Jun 4, 2023

Vision semi-GAPIC (#3373)

0e5c5d4

parthea pushed a commit that referenced this pull request Oct 21, 2023

Vision semi-GAPIC (#3373)

54fb4e0

parthea pushed a commit that referenced this pull request Oct 21, 2023

Vision semi-GAPIC (#3373)

db35d7c

parthea pushed a commit that referenced this pull request Oct 21, 2023

Vision semi-GAPIC (#3373)

00a4c62

parthea pushed a commit that referenced this pull request Oct 22, 2023

Vision semi-GAPIC (#3373)

13462a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vision semi-GAPIC #3373

Vision semi-GAPIC #3373

lukesneeringer commented May 4, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

		@@ -1,4 +1,4 @@
		include README.rst LICENSE
		include README.rst LICENSE requirements.txt

		@@ -0,0 +1 @@
		__import__('pkg_resources').declare_namespace(__name__)

		@@ -1,4 +1,4 @@
		# Copyright 2016 Google Inc.
		# Copyright 2017, Google Inc. All rights reserved.


		from __future__ import absolute_import

		from google.cloud.gapic.vision.v1 import image_annotator_client as iac

Vision semi-GAPIC #3373

Vision semi-GAPIC #3373

Conversation

lukesneeringer commented May 4, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.