Adding optional switch to capture project ID in from_service_account_json().

[dhermes]

Fixes #1883.

@lukesneeringer This is a long-standing bug but should really make it into a google-cloud-core release. I know you hate releasing core.

[theacodes]

It would be great to solve this by just consolidating ClientWithProject and ClientWithCredentials Client

[dhermes]

@jonparrott See the table I made about usage. The only issue with that is some APIs don't use a project (and we don't want to fail their constructors over a missing project).

[theacodes]

Does it help that google auth doesn't error if it can't determine a project?

[dhermes]

@jonparrott Mostly it doesn't help because it isn't true?

Or do you mean something else?

[theacodes]

That's if it doesn't find credentials, not if it doesn't find the project.

[dhermes]

But there is no google.auth.default_project?

[theacodes]

Right. This is part of the constraint. You should never get a project ID that didn't come from the same source as the credentials.

[dhermes]

Makes sense.

@lukesneeringer WDYT of us just using project on every Client instance? (This would just bring Client and ClientWithProject together, ClientWithProject is already a tiny impl.)

[tseaver]

FTR, ClientWithProject is skipped by the following:

$ for f in $(ls */google/cloud/*/client.py); do
       if ! grep -q ClientWithProject $f; then
           echo $f
       fi
  done
bigtable/google/cloud/bigtable/client.py
language/google/cloud/language/client.py
resource_manager/google/cloud/resource_manager/client.py
spanner/google/cloud/spanner/client.py
speech/google/cloud/speech/client.py
translate/google/cloud/translate/client.py

Of those, the following have _ClientProjectMixin included:

$ for f in $(ls */google/cloud/*/client.py); do
       if ! grep -q ClientWithProject $f; then
           echo $f
       fi
  done | xargs grep -l _ClientProjectMixin
bigtable/google/cloud/bigtable/client.py
spanner/google/cloud/spanner/client.py

[dhermes]

@tseaver This is (intended to be) captured in my table

[dhermes]

@tseaver Sorry I missed your LGTM 18 days ago.

It's good I got this in, in case we have a google-cloud-core release for your gRPC remap PR, this can go in too.