Add keyword arguments to google.cloud.storage.Bucket.get_blob. #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
added
api: storage
|
@tillahoffmann Thanks for the patch! Could you please add a unit test which exercises the |
|
@tseaver, added a test and also the encryption headers such that the |
tseaver
suggested changes
Jul 18, 2017
| @@ -33,7 +33,7 @@ | |||
| from google.cloud.storage._helpers import _validate_name | |||
| from google.cloud.storage.acl import BucketACL | |||
| from google.cloud.storage.acl import DefaultObjectACL | |||
| from google.cloud.storage.blob import Blob | |||
| from google.cloud.storage.blob import Blob, _get_encryption_headers | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| method='GET', path=blob.path, _target_object=blob) | ||
| method='GET', path=blob.path, _target_object=blob, | ||
| headers=headers | ||
| ) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| self.assertEqual(blob.name, BLOB_NAME) | ||
| kw, = connection._requested | ||
| self.assertEqual(kw['method'], 'GET') | ||
| self.assertEqual(kw['path'], '/b/%s/o/%s' % (NAME, BLOB_NAME)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Jul 19, 2017
|
Looks like #3627 fixes the master branch for those test errors. |
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
kwargsto theget_blobmethod ofgoogle.cloud.storage.Bucketto support passingchunk_size,encryption_keyand any future parameters theBlobconstructor may have.