Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying usage of Client classes in Spanner and Bigtable #3671

Closed
wants to merge 2 commits into from
Closed

Simplifying usage of Client classes in Spanner and Bigtable #3671

wants to merge 2 commits into from

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 25, 2017

As a follow-up commit, also simplifying the Client classes.

I am "throwing this up" as a half-finished PR so @jonparrott can take the wheel.

@dhermes dhermes added api: bigtable Issues related to the Bigtable API. api: spanner Issues related to the Spanner API. api: core do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 25, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2017
@theacodes
Copy link
Contributor

I'm gonna close this for now. This is helpful because it's revealed just how much refactoring will need to happen to use a new client superclass. With the move to google.api.core, I will introduce the new base classes, switch these to that, then drop core.client.

@theacodes theacodes closed this Jul 25, 2017
@dhermes
Copy link
Contributor Author

dhermes commented Jul 25, 2017

@jonparrott At the very least the first commit should go in (just to push all of the warts into one place)

@theacodes
Copy link
Contributor

Agreed, do you wanna send a new PR with just that?

@dhermes
Copy link
Contributor Author

dhermes commented Jul 25, 2017

I just force-pushed this branch with one fewer commit.

@dhermes
Copy link
Contributor Author

dhermes commented Jul 25, 2017

And the force-push made it impossible to "Reopen and comment"

@dhermes dhermes mentioned this pull request Jul 25, 2017
Merged
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@busunkim96
[dialogflow] fix: marking a test with flaky [(#3671)](GoogleCloudPlat…
cdb17b6 
…form/python-docs-samples#3671)

fixes #3490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@theacodes theacodes

Labels
api: bigtable Issues related to the Bigtable API. api: core api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @theacodes @googlebot