Annotate pylintrc w defaults and rationale #368

tseaver · 2014-11-10T21:47:14Z

Generated from 'pylint --generate-rcfile'.

Defaults are commented out.

Exceptions to defaults include a rationale.

Note generation of 'pylintrc_reduced'.

Minor changes to code to conform w/ new config.

Helper, not API; unused outside 'gcloud.datastore.helpers'. Removes pylintrc wart.

Generated from 'pylint --generate-rcfile'. Defaults are commented out. Exceptions to defaults include a rationale. Note generation of 'pylintrc_reduced'.

tseaver · 2014-11-10T21:47:42Z

@dhermes, @silvolu PTAL.

pylintrc_default

+# - Rules for test / demo code are generated into 'pylintrc_reduced'
+#   as deltas from this configuration by the 'run_pylint.py' script.
+#
+# - 'RATIONALE:  API mapping' as a defence for non-default settings is


coveralls · 2014-11-10T21:56:04Z

Changes Unknown when pulling e9e69f9 on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

pylintrc_default

+
+# Good variable names which should always be accepted, separated by a comma
+# DEFAULT:  good-names=i,j,k,ex,Run,_
+# RATIONALE:  'pb' adn 'id' have well-understood meainings in the code. 


pylintrc_default

+#                  identical implementation but different docstrings.
+# - star-args:  standard Python idioms for varargs:
+#                  ancestor = Key.from_path(*ancestor)
+disable =


coveralls · 2014-11-10T22:14:20Z

Changes Unknown when pulling 5e0f5c3 on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

coveralls · 2014-11-10T22:15:22Z

Changes Unknown when pulling 5e0f5c3 on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

tseaver · 2014-11-10T23:52:04Z

@dhermes any reason not to merge?

dhermes · 2014-11-11T01:39:56Z

Sorry, was in transit.

RE: YAGNI, I totally agree. However I've seen the unused_ prefix used a fair deal throughout large code-bases, but it's very possible we'll never have issue where we have to preserve an interface without requiring an argument.

In general, these were the kinds of discussions I wanted to have about the config so we can eliminate the churn.

@tseaver are we proposing this is the "frozen" final config or just a first step towards it?

tseaver · 2014-11-11T03:30:46Z

Given that I don't really believe in a "final" config, I'd say this is just a better config than what we have now: it drops some exclusions we no longer need, and documents the places where we adopt policies different than the out-of-the-box defaults. If we run up against future failures, it provides more information than we have now to decide whether to change the code or the pylintrc (by documenting all the defaults in place).

We could get to a "final" point for storage / datastore, and then still need to tweak it for either Py3k or a new API set (most of our explicit policies are due to API-mapping).

coveralls · 2014-11-11T14:18:24Z

Changes Unknown when pulling 1a79f4c on tseaver:annotate_pylintrc_w_defaults_and_rationale into * on GoogleCloudPlatform:master*.

tseaver · 2014-11-11T19:01:52Z

@dhermes OK to merge?

dhermes · 2014-11-11T22:07:21Z

LGTM

…_rationale Annotate pylintrc w defaults and rationale

* docs: Add documentation for latest models to RecognitionConfig PiperOrigin-RevId: 446200223 Source-Link: googleapis/googleapis@4f586ea Source-Link: googleapis/googleapis-gen@4ffe3d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZmZTNkOWZkZmYzY2M1NWRhNzBhNTZhOGM2NDM1ODdlMTZlMmZlOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: update to gapic-generator-python 1.5.0 feat: add support for `google.cloud.<api>.__version__` PiperOrigin-RevId: 484665853 Source-Link: googleapis/googleapis@8eb249a Source-Link: googleapis/googleapis-gen@c8aa327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update version in gapic_version.py * add .release-please-manifest.json with correct version * add owlbot.py to exclude generated gapic_version.py * set manifest to true in .github/release-please.yml * add release-please-config.json * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update path to snippet metadata json * chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9

Generate python samples templates in owlbot.py

…368) Source-Link: googleapis/synthtool@95d9289 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

* docs: update documentation to require certain fields PiperOrigin-RevId: 530345646 Source-Link: googleapis/googleapis@ae157a1 Source-Link: googleapis/googleapis-gen@1798b3d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTc5OGIzZDBiZDE2YzZmZmM2YTFjY2EzMWYzMTYyOTQyMzQ3MjdiYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: integrate gapic-generator-python-1.4.1 and enable more py_test targets PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This comment is required to so that release-please updates the version. See https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: allow releases on previous majors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: Add documentation for latest models to RecognitionConfig PiperOrigin-RevId: 446200223 Source-Link: googleapis/googleapis@4f586ea Source-Link: googleapis/googleapis-gen@4ffe3d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZmZTNkOWZkZmYzY2M1NWRhNzBhNTZhOGM2NDM1ODdlMTZlMmZlOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

tseaver added 3 commits November 10, 2014 16:18

Avoid confusing pylint's 'missing-format-attribute'.

2ff5883

Rename '_get_protobuf_attribute_and_value'->'_pb_attr_value'.

982c51c

Helper, not API; unused outside 'gcloud.datastore.helpers'. Removes pylintrc wart.

Annotate base pylintrc.

e9e69f9

Generated from 'pylint --generate-rcfile'. Defaults are commented out. Exceptions to defaults include a rationale. Note generation of 'pylintrc_reduced'.

tseaver added the hygiene label Nov 10, 2014

This was referenced Nov 10, 2014

Move 'bucket.BucketIterator' -> 'connection._BucketIterator'. #358

Merged

Fix #26: expose bucket iterator w extra params #359

Merged

Fix #354: support slash in key names #364

Merged

dhermes reviewed Nov 10, 2014
View reviewed changes

pylintrc_default

# Good variable names which should always be accepted, separated by a comma

# DEFAULT: good-names=i,j,k,ex,Run,_

# RATIONALE: 'pb' adn 'id' have well-understood meainings in the code.

This comment was marked as spam.

Sign in to view

tseaver added 2 commits November 10, 2014 17:00

US speling.

ecb5ded

Moar speling.

5e0f5c3

dhermes reviewed Nov 10, 2014
View reviewed changes

pylintrc_default

# identical implementation but different docstrings.

# - star-args: standard Python idioms for varargs:

# ancestor = Key.from_path(*ancestor)

disable =

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Update 'max-locals' as needed by #364.

1a79f4c

tseaver added a commit that referenced this pull request Nov 11, 2014

Merge pull request #368 from tseaver/annotate_pylintrc_w_defaults_and…

95e80e1

…_rationale Annotate pylintrc w defaults and rationale

tseaver merged commit 95e80e1 into googleapis:master Nov 11, 2014

tseaver deleted the annotate_pylintrc_w_defaults_and_rationale branch November 11, 2014 22:09

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.14.0 (#368)

4d10d5f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency google-cloud-bigquery to v3.4.1 (#368)

a6d42ec

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore: generate python samples templates in owlbot.py (#368)

90c139e

Generate python samples templates in owlbot.py

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.21.0 (#368)

45175da

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-storage to v2.2.1 (#368)

b1a8ebb

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update all dependencies (#368)

3199bf0

parthea added a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-analytics-admin to v0.19.0 (#368)

df4cca8

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 0.17.0 (#368)

1224c5d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 3.11.0 (#368)

b5a2a3b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Annotate pylintrc w defaults and rationale #368

Annotate pylintrc w defaults and rationale #368

tseaver commented Nov 10, 2014

tseaver commented Nov 10, 2014

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 10, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 10, 2014

coveralls commented Nov 10, 2014

tseaver commented Nov 10, 2014

dhermes commented Nov 11, 2014

tseaver commented Nov 11, 2014

coveralls commented Nov 11, 2014

tseaver commented Nov 11, 2014

dhermes commented Nov 11, 2014

Annotate pylintrc w defaults and rationale #368

Annotate pylintrc w defaults and rationale #368

Conversation

tseaver commented Nov 10, 2014

tseaver commented Nov 10, 2014

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 10, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 10, 2014

coveralls commented Nov 10, 2014

tseaver commented Nov 10, 2014

dhermes commented Nov 11, 2014

tseaver commented Nov 11, 2014

coveralls commented Nov 11, 2014

tseaver commented Nov 11, 2014

dhermes commented Nov 11, 2014