-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry streaming exceptions (redux) #3930
Closed
tseaver
wants to merge
14
commits into
googleapis:master
from
tseaver:3775-spanner-retry-streaming-exceptions-redux
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
487d178
Cleanups.
tseaver 2ce7040
Add required 'retry' arg to 'StreamedResultSet'.
tseaver 8817a32
Curry arguments to retry request on a resumable error.
tseaver 8334354
Remove 'resume_token' from 'Snapshot.{read,execute_sql}'.
tseaver 2abaccf
Rename 'SRS.retry' -> 'restart' for clarity.
tseaver 7b7221e
Tests match order of methods.
tseaver fc25964
Document/test that 'SRS.consume_next' propagates 'ServiceUnavailable'.
tseaver 1f688a6
In 'SRS.consume_next' don't copy empty 'resume_token'.
tseaver db9a2ab
'SRS.one_or_none': use 'consume_all'.
tseaver 6ce9864
Buffer accumulated rows until new token/last set/EOT.
tseaver c2356b8
Add 'SRS._do_restart' helper method.
tseaver a992856
'SRS.consume_next': invoke 'self._do_restart' on ServiceUnavailable.
tseaver 7d83816
On UNAVAILABLE w/o resume token, restart from scratch.
tseaver 8f47fe2
Curry transaction selector / options for restart of 'read'/'execute_s…
tseaver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.