Suppress instance creation tests by default on CI #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too many orphans, too little quota.
googlebot
added
the
cla: yes
dhermes
reviewed
Sep 13, 2017
| @@ -0,0 +1,24 @@ | |||
| from google.cloud.spanner import Client | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
reviewed
Sep 13, 2017
| @@ -0,0 +1,24 @@ | |||
| from google.cloud.spanner import Client | |||
| from .streaming_utils import INSTANCE_NAME as STREAMING_INSTANCE | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
|
|
||
| def scrub_instances(client): | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Yup, I pushed it to my fork, instead of the branch here from which I made the PR. |
|
I'm about to be out-of-pocket: merge at will. |
crwilcox
pushed a commit
to googleapis/python-spanner
that referenced
this pull request
Jan 31, 2020
* Fix 'populate_streaming' script after PR #3787. * Add utility for scrubbing orphaned instances. * Suppress instance creation tests by default on CI. Too many orphans, too little quota. * License header, formatting. Addresses: googleapis/google-cloud-python#3951 (comment) googleapis/google-cloud-python#3951 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have enough quota to risk orphans.
Fix
tests/system/utils/populate_streamingscript after PR Drop 'Database.read' and 'Database.execute_sql' convenience methods. #3787.Add utility for scrubbing orphaned instances.