Replace usage of google.api.core with google.api_core #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2017 13:26
theacodes
requested review from
duggelz,
liyanhui1228,
tseaver,
tswast and
waprin
as code owners
googlebot
added
the
cla: yes
dhermes
reviewed
Oct 18, 2017
There was a problem hiding this comment.
Mostly LGTM but you'll definitely need to update https://github.com/GoogleCloudPlatform/google-cloud-python/blob/961c70c267d7b08a40da51ed67fd1d2969ac202b/test_utils/scripts/get_target_packages.py#L174-L177
It may be easiest to just put it in PKG_DEPENDENCIES?
| # NOTE: This trumps the previous core/* directive, since the last match is | ||
| # what matters. | ||
| core/google/api/core/* @jonparrott | ||
| # Jon Wayne Parrott is the author of the new google.api_core library. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Good call on updating get_target_packages, done. |
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core. * s/google.api.core/google.api_core/g and nox updates * Fixing core tests, addressing review feedback * Fix bigquery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the big one- this replaces any usage of
api.corewithapi_coreand makesgoogle-cloud-coredepend ongoogle-api-core.