Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows selecting EVENTUAL consistency, rather than the STRONG default. Fixes #305.
tseaver
changed the title
tseaver
added
api: datastore
| opts = lookup_request.read_options | ||
| ro_enum = datastore_pb.ReadOptions.ReadConsistency | ||
| if eventual: | ||
| opts.read_consistency = ro_enum.Value('EVENTUAL') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dhermes PTAL: I think I addressed all your concerns. |
|
Code checks out, still need to check the tests. |
|
LGTM |
tseaver
added a commit
that referenced
this pull request
Dec 19, 2014
Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'.
tseaver
added a commit
that referenced
this pull request
Dec 19, 2014
Fix regression test failure introduced in PR #449.
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
…inding's list of attributes (#449) * feat: add cloud_dlp_inspection and cloud_dlp_data_profile fields to finding's list of attributes docs: miscellaneous style improvements PiperOrigin-RevId: 525798516 Source-Link: googleapis/googleapis@36a885f Source-Link: googleapis/googleapis-gen@c47a1b7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ3YTFiNzk5MjZlYjRiOWZjNDdmNDQ1YTNhODk3MTMxNDA3NWRlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
- [x] Regenerate this pull request now. PiperOrigin-RevId: 417030293 Source-Link: googleapis/googleapis@ebef8e6 Source-Link: googleapis/googleapis-gen@1395126 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTM5NTEyNjhiMDA5ZDk4ZDgyMzU1Y2NkOTY0N2Y0MzUwNTkwNjA5ZCJ9 feat(v2): added filter in list documentations request feat(v2): added option to import custom metadata from Google Cloud Storage in reload document request feat(v2): added option to apply partial update to the smart messaging allowlist in reload document request feat(v2): added filter in list knowledge bases request
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
🤖 I have created a release *beep* *boop* --- ## [2.11.0](googleapis/python-dialogflow@v2.10.0...v2.11.0) (2022-01-13) ### Features * support document metadata filter in article suggestion ([#442](googleapis/python-dialogflow#442)) ([6f615f9](googleapis/python-dialogflow@6f615f9)) * **v2:** added export documentation method ([#449](googleapis/python-dialogflow#449)) ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added filter in list documentations request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added filter in list knowledge bases request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added option to apply partial update to the smart messaging allowlist in reload document request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2:** added option to import custom metadata from Google Cloud Storage in reload document request ([a43d1e9](googleapis/python-dialogflow@a43d1e9)) * **v2beta1:** add support for knowledge_base in knowledge operation metadata ([0f60629](googleapis/python-dialogflow@0f60629)) * **v2beta1:** added option to configure the number of sentences in the suggestion context ([#453](googleapis/python-dialogflow#453)) ([e48ea00](googleapis/python-dialogflow@e48ea00)) * **v2beta1:** removed OPTIONAL for speech model variant ([#448](googleapis/python-dialogflow#448)) ([0f60629](googleapis/python-dialogflow@0f60629)) * **v2:** removed OPTIONAL for speech model variant ([#447](googleapis/python-dialogflow#447)) ([56efd10](googleapis/python-dialogflow@56efd10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Sep 22, 2023
* chore(bazel): update protobuf to v3.21.3 chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: googleapis/googleapis-gen@6a4d9d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Source-Link: googleapis/synthtool@050953d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows selecting EVENTUAL consistency, rather than the STRONG default.
Fixes #305.