Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin 'Getting started with gcloud' section on every page. #554

Closed
wants to merge 1 commit into from
Closed

Pin 'Getting started with gcloud' section on every page. #554

wants to merge 1 commit into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 15, 2015

Make it togglable, like the node docs.

Fixes #553.

@tseaver
Pin 'Getting stared with gcloud' section on every page.
7da6282 
Make it togglable, like the node docs.

Fixes #553.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Jan 15, 2015

To review, run tox -e docs and then open docs/_build/html/index.html.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7da6282 on tseaver:553-pin_getting_started_on_every_page into 55285f9 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Jan 15, 2015

@silvolu Just had a remark about this. I'll leave the review to him.

@silvolu
Copy link
Contributor

silvolu commented Jan 15, 2015

I think @jgeewax should review; I was just commenting on the historical reason why there is no pinning :)

@silvolu silvolu mentioned this pull request Jan 16, 2015
Closed
@dhermes dhermes changed the title Pin 'Getting stared with gcloud' section on every page. Pin 'Getting started with gcloud' section on every page. Jan 22, 2015
@dhermes
Copy link
Contributor

dhermes commented Mar 2, 2015

This is very much in limbo.

Do we need this and is #553 actually necessary?

/cc @jgeewax

@dhermes
Copy link
Contributor

dhermes commented Mar 31, 2015

Since this has languished for 2.5 months, I'm closing out. If we decided #533 is relevant, we can revisit.

@dhermes dhermes closed this Mar 31, 2015
@tseaver tseaver deleted the 553-pin_getting_started_on_every_page branch May 1, 2015 14:19
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#554)
35ab24a 
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#554)
9236444 
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#554)
237aef6 
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin the "getting started with gcloud" snippet at the top of every page
5 participants
@tseaver @coveralls @dhermes @silvolu @googlebot