Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses implicit behavior in storage regression #571

Merged
merged 1 commit into from
Jan 27, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 27, 2015

NOTE: Uses #570 as diffbase.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2015
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Jan 27, 2015
@dhermes dhermes force-pushed the use-implicit-behavior-in-storage branch from 04fc99a to 36a1617 Compare January 27, 2015 06:01
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 36a1617 on dhermes:use-implicit-behavior-in-storage into * on GoogleCloudPlatform:master*.

@tseaver
Copy link
Contributor

tseaver commented Jan 27, 2015

LGTM. My question about a mapping could be addressed in a future PR.

@dhermes dhermes force-pushed the use-implicit-behavior-in-storage branch from 36a1617 to c308d0b Compare January 27, 2015 18:48
@dhermes dhermes force-pushed the use-implicit-behavior-in-storage branch from c308d0b to 5722c8f Compare January 27, 2015 18:49
@dhermes
Copy link
Contributor Author

dhermes commented Jan 27, 2015

For posterity, here is the comment. (I forgot where I had seen it momentarily.)

On that note, I am considering having an _Environ class and using an instance of it as _implicit_environ.DEFAULTS in the same way _implicit_environ is currently used (as a namespace).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5722c8f on dhermes:use-implicit-behavior-in-storage into 168d3e5 on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Jan 27, 2015
Uses implicit behavior in storage regression
@dhermes dhermes merged commit 6bbb144 into googleapis:master Jan 27, 2015
@dhermes dhermes deleted the use-implicit-behavior-in-storage branch January 27, 2015 18:58
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 473833416

Source-Link: googleapis/googleapis@565a550

Source-Link: googleapis/googleapis-gen@1ee1a06
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants