Moving Bucket._patch_properties (and patch) to _PropertyMixin. #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
storage-remove-patch-properties-blob
branch
from
a295c2f
to
f85f0d9
Compare
| self._properties = self.connection.api_request( | ||
| method='PATCH', path=self.path, data=properties, | ||
| query_params={'projection': 'full'}) | ||
| self._changes.update(properties.keys()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM, module my quibble on |
Also updating tests of setters to require using patch() to actually send the update.
dhermes
force-pushed
the
storage-remove-patch-properties-blob
branch
from
f85f0d9
to
fcbffb5
Compare
dhermes
added a commit
that referenced
this pull request
Mar 13, 2015
…blob Moving Bucket._patch_properties (and patch) to _PropertyMixin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #688 as diffbase.Also updating
_PropertyBatchto call patch on__exit__.It seems removing
_patch_propertiesoutright is a possibility