Flesh out pubsub topics #742

tseaver · 2015-03-18T15:42:18Z

Following #691.

Updates the API docs slightly (making batching explicit).
Adds a connection lifted from gcloud.storage.connection.
Adds Topic class and list_topics API function.

Does not handle implicit connection / project ID stuff (which should be shared, as called for in #741).

Copied from 'storage.connection.Connection', with storage-specific bits (e.g., upload) removed.

Include 'create', 'delete', 'exists', and 'publish' methods. Inclue 'pubsub.topic.Topic.batch', which allows publishing multiple messages to a topic as a single API request.

docs/pubsub-api.rst

+
+   >>> from gcloud.pubsub.topic import Topic
+   >>> topic = Topic('topic_name')
+   >>> topic.create()  # API request


Addresses: #742 (comment)

Addresses: #742 (comment).

coveralls · 2015-03-18T19:43:41Z

Coverage remained the same at 100.0% when pulling cf8b9fa on tseaver:691-flesh_out_pubsub_topics into aa684be on GoogleCloudPlatform:master.

gcloud/pubsub/api.py

+    path = '/projects/%s/topics' % project
+    if params:
+        return connection.api_request(method='GET', path=path,
+                                      query_params=params)


[ci skip]

gcloud/pubsub/api.py

+""" Define API functions (not bound to classes)."""
+
+
+def list_topics(page_size=None, page_token=None,


Addresses: https://github.com/GoogleCloudPlatform/gcloud-python/pull/742/files#r26701080

coveralls · 2015-03-18T20:48:13Z

Coverage remained the same at 100.0% when pulling 9cd9cf6 on tseaver:691-flesh_out_pubsub_topics into aa684be on GoogleCloudPlatform:master.

Addresses: #742 (comment)

coveralls · 2015-03-19T00:34:07Z

Coverage remained the same at 100.0% when pulling 703d56b on tseaver:691-flesh_out_pubsub_topics into aa684be on GoogleCloudPlatform:master.

tseaver · 2015-03-19T16:35:20Z

@dhermes, any remaining issues? I could merge here and then you could work on refactoring the connection stuff.

dhermes · 2015-03-19T17:23:26Z

LGTM

Flesh out pubsub topics

tseaver added 4 commits March 18, 2015 10:24

Sketch 'gcloud.pubsub' API.

7deb85b

Add 'pubsub.connection.Connection'

832b98f

Copied from 'storage.connection.Connection', with storage-specific bits (e.g., upload) removed.

Add 'pubsub.topic.Topic' class.

fd69e33

Include 'create', 'delete', 'exists', and 'publish' methods. Inclue 'pubsub.topic.Topic.batch', which allows publishing multiple messages to a topic as a single API request.

Add 'pubsub.api.list_topics'.

3b5fa86

tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 18, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2015

This was referenced Mar 18, 2015

Sketch 'gcloud.pubsub' API. #691

Closed

First pass at stubbing out gcloud.pubsub. #237

Closed

dhermes reviewed Mar 18, 2015
View reviewed changes

docs/pubsub-api.rst

>>> from gcloud.pubsub.topic import Topic

>>> topic = Topic('topic_name')

>>> topic.create() # API request

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 3 commits March 18, 2015 14:55

Py3k compatibility for base64.

bc2b7bd

Add copyright, initial docstring.

4470178

Addresses: #742 (comment)

De-emphasize 'project' and 'connection' as args to 'list_topics'.

cf8b9fa

Addresses: #742 (comment).

This was referenced Mar 18, 2015

Flesh out pubsub subscriptions #743

Merged

Initial pubsub implementation plan #744

Closed

dhermes reviewed Mar 18, 2015
View reviewed changes

Note that the payload for a message is intened to be bytes.

301ea73

[ci skip]

dhermes reviewed Mar 18, 2015
View reviewed changes

Delete messages from batch after successful commit API return.

9cd9cf6

Addresses: https://github.com/GoogleCloudPlatform/gcloud-python/pull/742/files#r26701080

Don't bend over backward to avoid passing empty .

703d56b

Addresses: #742 (comment)

tseaver added a commit that referenced this pull request Mar 19, 2015

Merge pull request #742 from tseaver/691-flesh_out_pubsub_topics

01d697e

Flesh out pubsub topics

tseaver merged commit 01d697e into googleapis:master Mar 19, 2015

tseaver deleted the 691-flesh_out_pubsub_topics branch March 19, 2015 17:26

dhermes mentioned this pull request Mar 19, 2015

Move JSON / discovery connection to shared connection module #746

Merged

dhermes mentioned this pull request Mar 31, 2015

Adding Pub/Sub docs and JS to dedent for the section header. #785

Merged

dhermes mentioned this pull request Apr 9, 2015

Upgrading version to 0.5.0. #813

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flesh out pubsub topics #742

Flesh out pubsub topics #742

tseaver commented Mar 18, 2015

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Mar 18, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Mar 18, 2015

coveralls commented Mar 19, 2015

tseaver commented Mar 19, 2015

dhermes commented Mar 19, 2015

		""" Define API functions (not bound to classes)."""


		def list_topics(page_size=None, page_token=None,

Flesh out pubsub topics #742

Flesh out pubsub topics #742

Conversation

tseaver commented Mar 18, 2015

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Mar 18, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Mar 18, 2015

coveralls commented Mar 19, 2015

tseaver commented Mar 19, 2015

dhermes commented Mar 19, 2015