Add parameterized test for from_rfc3339 with nanos #7675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sduskis
approved these changes
Apr 8, 2019
tseaver
suggested changes
Apr 17, 2019
There was a problem hiding this comment.
The WebRisk failure seems clearly unrelated. However, the API core failures (lint, pytype) need to be fixed.
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
|
The failures are unrelated. This is a test only change. Merging |
|
@crwilcox We still need to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into another issue I noticed we didn't seem to test this constructor much (if at all).